fix: mirror question mark icon in RTL layouts#1348
Open
Phoenix1808 wants to merge 1 commit into
Open
Conversation
The reproducible-builds help icon next to the Versions header always rendered the LTR ? glyph. Adding android:autoMirrored=true lets it flip horizontally in RTL locales so it reads as the Arabic ؟. Fixes Droid-ify#1229
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix RTL rendering of reproducible-builds help icon
What
The help icon (
?) displayed next to the Versions section header (which links to information about reproducible builds) was always rendered as the left-to-right Latin question mark, even when the application was running in a right-to-left (RTL) locale such as Arabic.In Arabic, the correct question mark is
؟, which is visually mirrored compared to the Latin?. Since the drawable was not configured for RTL mirroring, the icon appeared inconsistent with the rest of the localized interface.Before
Help icon rendered as
?in Arabic (RTL) layouts.After
Help icon is automatically mirrored and rendered as
؟in RTL layouts.No visual changes in LTR locales.
Change
Enabled automatic RTL mirroring for the question mark vector drawable by adding:
Screenshots
Before
After
Fixes #1229