Skip to content

Patches holo synths#1098

Open
desertmote wants to merge 2 commits into
masterfrom
hoolooo
Open

Patches holo synths#1098
desertmote wants to merge 2 commits into
masterfrom
hoolooo

Conversation

@desertmote

Copy link
Copy Markdown
Collaborator

About The Pull Request

Fixes issues with prior merged PR.

Why It's Good For The Game

sdfgsdkjg sfdh

Changelog

🆑
fix: Adds back lost customizability to holo synths
/:cl:

target.dna.features[FEATURE_HOLO_COLOR] = rgb(rbg_value[1], rbg_value[2], rbg_value[3], (HOLOSYNTH_OPACITY * 255))

/datum/preference/color/holosynth_color/create_default_value()
return sanitize_hexcolor("[pick("7F", "FF")][pick("7F", "FF")][pick("7F", "FF")]")

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally this should be the past default colour

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is #7db4e1, by the way!

@github-actions

Copy link
Copy Markdown

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Pest removal; Bugs Stale UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants