Truncate tool names to 50 characters#14
Merged
Merged
Conversation
another-yijiao
approved these changes
Jun 4, 2026
another-yijiao
left a comment
another-yijiao
left a comment
There was a problem hiding this comment.
Looks good, didn't test locally.
Some clients add a prefix to tool names such as "doppler:", and any tools with computed names > 64 characters are ignored. This change helps mitigate that issue for those clients.
This also removes the explicit pnpm version from workflows, since it's not required when packageManager is set in package.json
emily-curry
force-pushed
the
emily/tool-name-truncation
branch
from
044aa67 to
2684ef4
Compare
|
Thanks for addressing #13! I tested it out and the message no longer appears. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change cuts down on the length of generated tool names, to ensure they stay far below the 64 character limit.
Fixes #13.