Skip to content

Make Helm chart resource limits/requests configurable #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paymog wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make Helm chart resource limits/requests configurable #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,9 @@ charts: manifests kustomize helm-tool yq dist
$(YQ) e 'select(.kind != "CustomResourceDefinition")' dist/recommended.yaml > $(CHART_DIR)/templates/all.yaml
cp hack/helm/Chart.yaml $(CHART_DIR)/
cp hack/helm/NOTES.txt $(CHART_DIR)/templates/
touch $(CHART_DIR)/values.yaml
cp hack/helm/values.yaml $(CHART_DIR)/
# Replace hardcoded manager container resources with Helm-configurable values
perl -i -0777 -pe 's/( resources:\n) limits:\n cpu: 100m\n memory: 256Mi\n requests:\n cpu: 100m\n memory: 256Mi/$$1 {{- toYaml .Values.resources | nindent 12 }}/g' $(CHART_DIR)/templates/all.yaml
helm package $(CHART_DIR) --version $(VERSION)

deploy: manifests kustomize ## Deploy controller to the K8s cluster specified in ~/.kube/config.
Expand Down
7 changes: 7 additions & 0 deletions hack/helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
resources:
limits:
cpu: 100m
memory: 256Mi
requests:
cpu: 100m
memory: 256Mi