perf(lifecycle): Prevent rerender of child components that use $liste…#1
Open
Domino9697 wants to merge 1 commit into
Open
perf(lifecycle): Prevent rerender of child components that use $liste…#1Domino9697 wants to merge 1 commit into
Domino9697 wants to merge 1 commit into
Conversation
…ners Child components that use the $listeners attribute are rerendered each time the parent component is updated. This is due to the updateChildComponent function that sets the reactive property vm.$listeners thus triggering a rerender of the child component. The problem is that we cannot check if the listeners were updated as we cannot compare functions. This change therefore provides a new toggleNotifyingSubscribers method that disables a reactive property's ability to notify its subscribers. We use this method to prevent the vm.$listeners property from rerendering the child component. fix vuejs#7257
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Child components that use the $listeners attribute are rerendered each time the parent component is
updated. This is due to the updateChildComponent function that sets the reactive property
vm.$listeners thus triggering a rerender of the child component. The problem is that we cannot check
if the listeners were updated as we cannot compare functions. This change therefore provides a new
toggleNotifyingSubscribers method that disables a reactive property's ability to notify its
subscribers. We use this method to prevent the vm.$listeners property from rerendering the child
component.
fix vuejs#7257