Repository navigation
[IDEV-2644] fix: guard against null fields in CheckPivotableDomains to prevent Nonetype iteration error - #40
Merged
Merged
Conversation
…neType iteration error
briluza
changed the base branch from
domaintools-iris-v2.2.13
to
domaintools-iris-v2.2.12
September 16, 2026 14:12
briluza
changed the base branch from
domaintools-iris-v2.2.12
to
domaintools-iris-v2.2.13
September 16, 2026 14:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
Fixes IDEV-2644
Description
Fixed a bug in the CheckPivotableDomains script where null values in domain data fields (e.g. SSLCertificate, MailServers, IPAddresses, NameServers, SOAEmail, GoogleAdsenseTrackingCode) caused a 'NoneType' object is not iterable crash. Added or [] / or {} fallback guards at all 12 affected call sites in check_pivotable_domains, matching the existing guard pattern already used in check_pivotable_nameserver_host_or_domain. Added a test case covering the null fields scenario.
Must have