chore(tsconfig): drop deprecated baseUrl in favor of relative paths#4698
Open
gentslava wants to merge 1 commit into
Open
chore(tsconfig): drop deprecated baseUrl in favor of relative paths#4698gentslava wants to merge 1 commit into
gentslava wants to merge 1 commit into
Conversation
baseUrl is deprecated and will stop working in TypeScript 7.0 (newer TS versions surface a "Specify ignoreDeprecations: 6.0" warning). Every tsconfig only uses baseUrl together with paths, and all path mappings are already relative, so since TS 4.1 they keep resolving from each tsconfig's own directory without baseUrl. Removes the deprecation without needing ignoreDeprecations. Verified locally: server typecheck + build (tsc + tsc-alias), api and schedules typecheck, dokploy @/ and @dokploy/* resolution, and the vitest suite all pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dosubot
Bot
added
the
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
baseUrlis deprecated in TypeScript and will stop working in TypeScript 7.0 — newer TypeScript versions surface a "Option 'baseUrl' is deprecated… Specify compilerOption '"ignoreDeprecations": "6.0"'" warning in the editor.Every tsconfig in the repo only uses
baseUrltogether withpaths, and all of those path mappings are already relative (./*,../../packages/server/src/*,./src/*). Since TypeScript 4.1 relativepathsresolve from each tsconfig's own directory withoutbaseUrl, so this simply removesbaseUrlfrom all 6 tsconfig files. That clears the deprecation cleanly, without resorting toignoreDeprecations.Files touched:
apps/dokploy/tsconfig.json,apps/dokploy/tsconfig.server.jsonpackages/server/tsconfig.json,packages/server/tsconfig.server.jsonapps/api/tsconfig.jsonapps/schedules/tsconfig.jsonNo behavior change — only the now-redundant
baseUrloption is removed.Checklist
Before submitting this PR, please make sure that:
canarybranch.packages/server/apps/api/apps/schedulestypecheck cleanly, the server build (tsc+tsc-alias) succeeds,@/and@dokploy/*still resolve inapps/dokploy, and the vitest suite passes.Issues related (if applicable)
n/a
Screenshots (if applicable)
n/a — config-only change.