Skip to content

fix: resolve 4 critical dependency vulnerabilities via scoped overrides#4681

Open
vikyw89 wants to merge 1 commit into
Dokploy:canaryfrom
vikyw89:fix/critical-audit-vulns
Open

fix: resolve 4 critical dependency vulnerabilities via scoped overrides#4681
vikyw89 wants to merge 1 commit into
Dokploy:canaryfrom
vikyw89:fix/critical-audit-vulns

Conversation

@vikyw89

@vikyw89 vikyw89 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

What

Adds scoped pnpm.overrides to the root package.json that pin only the vulnerable version ranges of three packages to their patched minimums:

"protobufjs@<7.5.5": ">=7.5.5",
"vitest@>=4.0.0 <4.1.0": ">=4.1.0",
"shell-quote@<=1.8.3": ">=1.8.4"

Why

pnpm audit reports 4 critical advisories (3 distinct packages):

Package Advisory Patched Path
shell-quote GHSA-w7jw-789q-3m8p >=1.8.4 direct dep of apps/dokploy
vitest GHSA-5xrq-8626-4rwp >=4.1.0 apps/dokploy; transitively via better-auth
protobufjs GHSA-xq3m-2v4x-88gg >=7.5.5 transitive under OpenTelemetry/gRPC

protobufjs is purely transitive (7 levels deep), so an override is the only way to fix it without waiting on upstream.

Verification

  • pnpm install → exit 0, lockfile updated.
  • pnpm audit0 criticals (237 → 222 total).

Notes

  • Scoped selectors (package@range) only touch the vulnerable versions; everything else resolves as before.
  • vitest 4.0.x → 4.1.x is a minor, dev/test-only bump.

Closes #4680

🤖 Generated with Claude Code

pnpm audit reported 4 critical advisories. Pin only the vulnerable
ranges to their patched minimums via scoped pnpm.overrides:

- shell-quote <=1.8.3 -> >=1.8.4  (GHSA-w7jw-789q-3m8p, direct dep)
- vitest >=4.0.0 <4.1.0 -> >=4.1.0 (GHSA-5xrq-8626-4rwp)
- protobufjs <7.5.5 -> >=7.5.5     (GHSA-xq3m-2v4x-88gg, transitive)

Scoped selectors leave all other versions untouched. Verified
pnpm install succeeds and pnpm audit reports 0 criticals (237 -> 222).

Closes Dokploy#4680

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@vikyw89 vikyw89 requested a review from Siumauricio as a code owner June 22, 2026 15:03
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve 4 critical dependency vulnerabilities (protobufjs, vitest, shell-quote) reported by pnpm audit

1 participant