feat: cascade video duplicate detection #237
Merged
Merged
Conversation
Two-tier scheme: cheap metadata gate (thumbnail dHash + duration), then ffmpeg keyframe comparison only on collisions. Scope: video only.
Add FFMPEG_TIMEOUT_MS = 30_000L and replace unbounded waitFor() with waitFor(timeout, TimeUnit.MILLISECONDS) + destroyForcibly() to prevent IO thread hangs. Also add a comment in findVideoCandidates clarifying that the hash-only fallback returns at most one candidate (LIMIT 1).
…atch edges Add integration tests for the video-specific repository query (distance gate and duration window) and the frame_hashes BIGINT[] Hibernate round-trip. Add unit tests for the non-majority framesMatch edge case and hammingDistance boundary values (0→0 and 0→0xFF).
Reduce DuplicateMediaChecker to thin DB ops (findImageCandidate, record, shiftToCurrent) and orchestrate both the image and video paths uniformly in SeenMemeHandler, splitting handleMessage into handleImage/handleVideo. Rename MediaHash.duration to durationSeconds to make the unit explicit, extract all keyframes in a single ffmpeg invocation, and trim feature-specific and business-logic detail from CLAUDE.md and the repository KDoc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.