added the emoji feature by IqraS-gif · Pull Request #92 · DhanushNehru/scratchpad-scribe

IqraS-gif · 2025-10-20T15:06:10Z

Features Added in `emoji-tag` Branch

1. Emoji-Based Tags

Added a feature to tag notes using emojis.

Example of a tag added:

2. Search by Emoji

Users can search notes using emoji tags.

3. Auto Tag Suggestion

Automatically suggests tags based on keywords.

Closes #34

vercel · 2025-10-20T15:06:15Z

@IqraS-gif is attempting to deploy a commit to the Dhanush Nehru's projects Team on Vercel.

A member of the Team first needs to authorize it.

IqraS-gif · 2025-10-20T15:06:33Z

hey @DhanushNehru kindly review the pr

IqraS-gif · 2025-10-21T09:27:22Z

hey @DhanushNehru any updates ?

vercel · 2025-10-22T17:02:45Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
scratchpad-scribe	Ready	Preview	Comment	Oct 23, 2025 2:34pm

DhanushNehru · 2025-10-22T17:03:06Z

Deployment failed @IqraS-gif

Copilot

Pull Request Overview

This PR adds emoji-based tagging functionality to the notes application, enabling users to categorize notes with emoji tags, search by those tags, and receive automatic tag suggestions based on note content.

Key Changes:

Implemented emoji tag system with emoji picker integration using @emoji-mart/react
Enhanced search to filter notes by tag labels and emoji characters
Added auto-suggestion feature that recommends tags based on keywords in note content

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
src/components/NotesSidebar.tsx	Updated search filter logic to support emoji and tag matching; modified toast API calls to use object parameter format
src/components/NoteEditor.tsx	Added tag management UI with emoji picker, tag input field, and keyword-based auto-suggestions; integrated third-party emoji library
src/components/NoteCard.tsx	Added visual display of tags as badges in the note card preview

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-22T17:03:31Z

                doc.text(activeNote.title || 'Untitled Note', margin, margin);
+
+                doc.setFontSize(10);
+                const tagString = activeNote.tags.map(t => `${t.emoji} ${t.label}`).join(', ');


Accessing activeNote.tags without checking if it exists will cause a runtime error if tags is undefined. Add optional chaining: activeNote.tags?.map(...) or use a default empty array.

Suggested change

const tagString = activeNote.tags.map(t => `${t.emoji} ${t.label}`).join(', ');

const tagString = (activeNote.tags ?? []).map(t => `${t.emoji} ${t.label}`).join(', ');

Copilot · 2025-10-22T17:03:31Z

                isActive={note.id === activeNoteId}
                onClick={() => onSelectNote(note.id)}
-                onDelete={() => onDelete(note.id)}
+                onDelete={onDelete || (() => {})}


The fallback to an empty function is unnecessary since onDelete is a required prop in the component signature. If the intention is to make it optional, update the NotesSidebarProps interface accordingly.

Suggested change

onDelete={onDelete || (() => {})}

onDelete={onDelete}

Copilot · 2025-10-22T17:03:32Z

+                        onEmojiSelect={handleEmojiSelect}
+                        theme="auto" 
+                        previewPosition="none"
+                        // REMOVED: searchPosition="none" -> The search bar is now visible by default


This comment describes a removal that isn't shown in the diff. Since removed code isn't visible here, the comment is misleading. Either remove this comment or rephrase it to explain the current configuration without referencing removed code.

Suggested change

// REMOVED: searchPosition="none" -> The search bar is now visible by default

// The search bar is visible by default

Copilot · 2025-10-22T17:03:32Z

+            <Button 
+                size="sm" 
+                onClick={handleAddTag} 
+                disabled={newTagInput.label.trim() === '' || tags.length >= 5}


The magic number 5 for max tags is hardcoded in multiple places (lines 103, 241, 249, 266). Extract this into a constant like MAX_TAGS_PER_NOTE at the top of the file for better maintainability.

Copilot · 2025-10-22T17:03:32Z

+          <div className="flex flex-wrap gap-1 mb-2">
+            {note.tags.map(tag => (
+              // Display tag as [emoji] [text]
+              <Badge key={tag.label} variant="outline" className="text-xs px-1.5 py-0.5 font-normal border-primary/50 text-primary/80 dark:border-primary-foreground/20 dark:text-primary-foreground/80">


Using tag.label as the key could cause issues if duplicate labels exist (though the editor prevents this). Consider using a combination like ${tag.emoji}-${tag.label} or adding a unique ID to the Tag type for a more robust key.

Suggested change

<Badge key={tag.label} variant="outline" className="text-xs px-1.5 py-0.5 font-normal border-primary/50 text-primary/80 dark:border-primary-foreground/20 dark:text-primary-foreground/80">

<Badge key={`${tag.emoji}-${tag.label}`} variant="outline" className="text-xs px-1.5 py-0.5 font-normal border-primary/50 text-primary/80 dark:border-primary-foreground/20 dark:text-primary-foreground/80">

IqraS-gif · 2025-10-22T17:25:08Z

I will look into it by Tomorrow

learner-enthusiast · 2025-10-23T03:04:08Z

The pipeline is failing i think you have added some packages push the package.json file as well

IqraS-gif · 2025-10-23T04:02:54Z

The pipeline is failing i think you have added some packages push the package.json file as well

yes exactly , my bad!

IqraS-gif · 2025-10-23T04:03:13Z

hey @DhanushNehru fixed the package.json issue, kindly check again

Copilot

Pull Request Overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-23T14:36:14Z

+const KEYWORD_SUGGESTIONS: { keyword: string, emoji: string, label: string }[] = [
+    { keyword: "bug", emoji: "🐛", label: "Bug" },
+    { keyword: "error", emoji: "🐞", label: "Issue" },
+    { keyword: "todo", emoji: "✅", label: "Task" },
+    { keyword: "fix", emoji: "🛠️", label: "Fix" },
+    { keyword: "plan", emoji: "📅", label: "Planning" },
+    { keyword: "idea", emoji: "💡", label: "Idea" },
+    { keyword: "concept", emoji: "🧠", label: "Concept" },
+    { keyword: "project", emoji: "🚀", label: "Project" },
+];


[nitpick] The KEYWORD_SUGGESTIONS constant is defined within the component file but could be moved to a separate constants file or configuration module for better maintainability and reusability across the application.

Copilot · 2025-10-23T14:36:14Z

+  const getSuggestions = (noteContent: string, currentTags: Tag[]): Tag[] => {
+    if (!noteContent || currentTags.length >= 5) return [];


The magic number 5 for maximum tags appears both here and on line 246. This should be extracted as a named constant (e.g., MAX_TAGS_PER_NOTE) to improve maintainability and ensure consistency.

added the emoji feature

9abdd38

DhanushNehru requested a review from Copilot October 22, 2025 17:02

vercel Bot had a problem deploying to Preview October 22, 2025 17:02 Failure

Copilot AI reviewed Oct 22, 2025

View reviewed changes

updated package.json

1f9c5a5

DhanushNehru requested a review from Copilot October 23, 2025 14:34

vercel Bot deployed to Preview October 23, 2025 14:34 View deployment

Copilot AI reviewed Oct 23, 2025

View reviewed changes

DhanushNehru merged commit 2fc45d9 into DhanushNehru:main Oct 23, 2025
5 checks passed

learner-enthusiast added hacktoberfest hacktoberfest-accepted labels Oct 27, 2025

	const tagString = activeNote.tags.map(t => `${t.emoji} ${t.label}`).join(', ');
	const tagString = (activeNote.tags ?? []).map(t => `${t.emoji} ${t.label}`).join(', ');

	// REMOVED: searchPosition="none" -> The search bar is now visible by default
	// The search bar is visible by default

	<Badge key={tag.label} variant="outline" className="text-xs px-1.5 py-0.5 font-normal border-primary/50 text-primary/80 dark:border-primary-foreground/20 dark:text-primary-foreground/80">
	<Badge key={`${tag.emoji}-${tag.label}`} variant="outline" className="text-xs px-1.5 py-0.5 font-normal border-primary/50 text-primary/80 dark:border-primary-foreground/20 dark:text-primary-foreground/80">

		const getSuggestions = (noteContent: string, currentTags: Tag[]): Tag[] => {
		if (!noteContent \|\| currentTags.length >= 5) return [];

Uh oh!

Conversation

IqraS-gif commented Oct 20, 2025

Features Added in emoji-tag Branch

1. Emoji-Based Tags

2. Search by Emoji

3. Auto Tag Suggestion

Uh oh!

vercel Bot commented Oct 20, 2025

Uh oh!

IqraS-gif commented Oct 20, 2025

Uh oh!

IqraS-gif commented Oct 21, 2025

Uh oh!

vercel Bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DhanushNehru commented Oct 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

IqraS-gif commented Oct 22, 2025

Uh oh!

learner-enthusiast commented Oct 23, 2025

Uh oh!

IqraS-gif commented Oct 23, 2025

Uh oh!

IqraS-gif commented Oct 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Features Added in `emoji-tag` Branch

vercel Bot commented Oct 22, 2025 •

edited

Loading