Fix shortcuts implementation by Jonniie · Pull Request #73 · DhanushNehru/scratchpad-scribe

Jonniie · 2025-10-11T12:50:25Z

Add delete confirmation dialog for shortcut delete action and fix duplicate note shortcut action

…ty toggle

…tcuts for note actions (duplicate notes)

vercel · 2025-10-11T12:50:29Z

Someone is attempting to deploy a commit to the Dhanush Nehru's projects Team on Vercel.

A member of the Team first needs to authorize it.

Jonniie · 2025-10-14T18:12:38Z

@DhanushNehru kindly review the open PRs

vercel · 2025-10-15T08:20:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
scratchpad-scribe	Ready	Preview	Comment	Oct 19, 2025 3:35pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

Copilot

Pull Request Overview

This PR enhances the shortcuts implementation by adding a confirmation dialog for note deletion and reorganizing the duplicate note shortcut from Ctrl/Cmd+D to Ctrl/Cmd+Shift+D to avoid conflicts. Additionally, it improves the authentication modal with password visibility toggles and confirmation fields.

Added delete confirmation dialog to prevent accidental note deletion
Moved duplicate note shortcut to Ctrl/Cmd+Shift+D and added Shift+D as alternative
Enhanced authentication modal with password visibility controls and confirmation field

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/pages/Index.tsx	Implements delete confirmation dialog, reorganizes keyboard shortcuts, and updates shortcut documentation
src/components/ui/AuthModal.tsx	Adds password visibility toggles and confirm password field for registration

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-15T08:20:39Z

+      if (isShift && !isCtrlOrMeta) {
+        switch (key) {
+          case "d": {
+            event.preventDefault();
+            event.stopPropagation();
+            if (activeNoteId) {
+              handleDuplicateNote(activeNoteId);
+              toast.success("Note duplicated");
+            }
+            break;
+          }
+        }
+      }


Duplicate code: The Shift+D case (lines 162-170) contains identical logic to the Ctrl/Cmd+Shift+D case (lines 147-155). Consider extracting this logic into a shared function to avoid code duplication.

Copilot · 2025-10-15T08:20:39Z

+                    <kbd className="px-2 py-0.5 bg-muted rounded border border-border font-mono">
+                      Ctrl+Shift+D
+                    </kbd>
+                  </div>


The shortcut documentation only shows 'Ctrl+Shift+D' but the code also supports 'Shift+D' alone. The documentation should reflect both available shortcuts or clarify which is the primary one.

Suggested change

<kbd className="px-2 py-0.5 bg-muted rounded border border-border font-mono">

Ctrl+Shift+D

</kbd>

</div>

<div className="flex gap-2">

<kbd className="px-2 py-0.5 bg-muted rounded border border-border font-mono">

Ctrl+Shift+D

</kbd>

<span className="text-xs text-muted-foreground">or</span>

<kbd className="px-2 py-0.5 bg-muted rounded border border-border font-mono">

Shift+D

</kbd>

</div>

…navigation logic

Jonniie · 2025-10-15T10:17:09Z

@DhanushNehru All suggestions reviewed and fixed

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Jonniie · 2025-10-17T10:18:46Z

@DhanushNehru kindly merge now

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-19T15:33:12Z

+                  <div className="flex items-center justify-between gap-4">
+                    <span>Duplicate note</span>
+                    <div className="flex items-center gap-2">
+                      <kbd className="px-2 py-0.5 bg-muted rounded border border-border font-mono">
+                        Shift+D
+                      </kbd>
+                      <span className="text-muted-foreground">or</span>
+                      <kbd className="px-2 py-0.5 bg-muted rounded border border-border font-mono">
+                        Cmd/Ctrl+Shift+D
+                      </kbd>
+                    </div>
+                  </div>


The keyboard shortcut documentation shows 'Shift+D' as an option for duplicating notes, but this shortcut is not implemented in the handleKeyDown function. Only 'Ctrl/Cmd+Shift+D' is actually handled.

Copilot · 2025-10-19T15:33:12Z

-
+          <div
+            className="w-16 h-0.5 mx-auto my-2 rounded-full bg-gradient-to-r from-orange-500 via-orange-400 to-orange-100"
+          ></div>


The empty div tag should be self-closing for consistency with JSX best practices.

Suggested change

></div>

/>

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-19T15:35:49Z

+      const isShift = event.shiftKey;

+      // Handle Ctrl/Cmd + key combinations
+      if (isCtrlOrMeta && !isShift) {


The keyboard shortcut handling logic has an issue where isShift is extracted but the condition !isShift in line 118 will prevent Shift+key combinations from being processed in the first block, even though some shortcuts might legitimately use Shift modifiers.

Suggested change

if (isCtrlOrMeta && !isShift) {

if (isCtrlOrMeta) {

Copilot · 2025-10-19T15:35:50Z

+          <div
+            className="w-16 h-0.5 mx-auto my-2 rounded-full bg-gradient-to-r from-orange-500 via-orange-400 to-orange-100"
+          ></div>


[nitpick] The self-closing div tag should use the more conventional <div></div> format instead of <div></div> for better readability and consistency with JSX conventions.

learner-enthusiast · 2025-10-20T06:12:03Z

Can you attach a video based on current deployed version and your branch in local

…mentation

…atchpad-scribe into fix-shortcuts-implementation

Jonniie · 2025-10-22T19:59:46Z

@DhanushNehru I've resolved the merge conflic here as well

github-actions added 2 commits October 11, 2025 13:13

feat(auth): Enhance AuthModal with password confirmation and visibili…

396397c

…ty toggle

feat(Index): Add delete confirmation dialog and enhance keyboard shor…

39e2b43

…tcuts for note actions (duplicate notes)

DhanushNehru requested a review from Copilot October 15, 2025 08:20

vercel Bot deployed to Preview October 15, 2025 08:20 View deployment

Copilot AI reviewed Oct 15, 2025

View reviewed changes

github-actions added 2 commits October 15, 2025 11:05

fix): Refactor note duplication logic into a separate function

02b5a6f

refactor(Index): Optimize note handling with useCallback and improve …

50063e9

…navigation logic

DhanushNehru requested a review from Copilot October 17, 2025 10:07

vercel Bot deployed to Preview October 17, 2025 10:07 View deployment

Copilot AI reviewed Oct 17, 2025

View reviewed changes

Comment thread src/pages/Index.tsx Outdated

Comment thread src/components/ui/AuthModal.tsx Outdated

Jonniie and others added 2 commits October 17, 2025 11:17

Update src/pages/Index.tsx

bf6ff06

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/components/ui/AuthModal.tsx

82c339b

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

DhanushNehru requested a review from Copilot October 19, 2025 15:32

Copilot AI reviewed Oct 19, 2025

View reviewed changes

DhanushNehru requested a review from Copilot October 19, 2025 15:35

DhanushNehru assigned Jonniie Oct 19, 2025

vercel Bot deployed to Preview October 19, 2025 15:35 View deployment

Copilot AI reviewed Oct 19, 2025

View reviewed changes

github-actions added 3 commits October 22, 2025 20:57

Merge remote-tracking branch 'upstream/main' into fix-shortcuts-imple…

f0d9845

…mentation

fix eye icon import

d42c6af

Merge branch 'fix-shortcuts-implementation' of github.com:Jonniie/scr…

cdee5ed

…atchpad-scribe into fix-shortcuts-implementation

Uh oh!

Conversation

Jonniie commented Oct 11, 2025

Uh oh!

vercel Bot commented Oct 11, 2025

Uh oh!

Jonniie commented Oct 14, 2025

Uh oh!

vercel Bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Jonniie commented Oct 15, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Jonniie commented Oct 17, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 19, 2025

Choose a reason for hiding this comment

Uh oh!

learner-enthusiast commented Oct 20, 2025

Uh oh!

Jonniie commented Oct 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel Bot commented Oct 15, 2025 •

edited

Loading