fix: show confirmation popup for delete shortcut and add toast#100
Conversation
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
|
@JeevaRamanathan is attempting to deploy a commit to the Dhanush Nehru's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @DhanushNehru, could you please review this PR when you get a chance |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a confirmation dialog for note deletion with enhanced user feedback. The changes ensure users confirm before deleting notes and provide clear feedback about which notes are being deleted or duplicated.
Key changes:
- Added confirmation dialog with note title display for delete operations triggered via keyboard shortcut
- Enhanced toast notifications to show the specific note title when deleting or duplicating notes
- Updated existing delete confirmation dialogs in NoteCard and NoteEditor to display the note title
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/pages/Index.tsx | Added delete confirmation dialog for keyboard shortcut deletion, implemented pendingDeleteId state management, and enhanced toast notifications with note titles |
| src/components/NoteEditor.tsx | Updated delete confirmation dialog to display the note title being deleted |
| src/components/NoteCard.tsx | Updated delete confirmation dialog to display the note title being deleted |
Comments suppressed due to low confidence (1)
src/pages/Index.tsx:1
- There are two consecutive question marks. The first '?' at the end of 'this note' should be removed since there's already a question mark after the closing span tag.
import { useState, useEffect, useCallback } from "react";
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
|
Hi @DhanushNehru, updated as per copilot suggestion and fixed the conflicts |
Fixes #99