Skip to content

Add pouring tasks, fluid replay and DexUni DFSPH prototype - #790

Merged
yuecideng merged 98 commits into
mainfrom
feat/dexuni-fluid-prototype
Nov 12, 2026
Merged

yuecideng merged 98 commits into
mainfrom
feat/dexuni-fluid-prototype

Conversation

@kioxli

@kioxli kioxli commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Adapt the pouring task, diagnostic replay and the standalone DexUni robot demonstration to the current fluid foundation in #777. The task now uses DexUni with nested DFSPH configuration, follows the relocated task and robot packages, and records current camera frames at the configured control rate.

Fluid trajectories now use the ordinary Gym replay modes: kinematic and control restore recorded robot, rigid-body and full particle positions/velocities without advancing physics; dynamic restores the initial particle state and replays controller actions through DexUni. The ordinary run-task collection path now qualifies the pour and publishes bounded particle sidecars with --record-trajectory --record-fluid-state; the separate fluid runner and FluidReplayEnv are removed.

The fluid deployment uses an 80-sample minimum, a 25 ms control interval (six 1/240 s physics steps), and a 1.5 rad/s² planning acceleration budget. PourOptions.rotation_duration now time-stretches each outward tilt and return leg to at least four seconds when the planned motion is shorter; it no longer fills the requested duration with terminal holds. The authored Franka joint speed caps remain in force. A fluid-only embodiment supplies stronger simulated gripper contact; ordinary Newton deployments keep their calibration. The standalone DexUni demonstration uses the same task policy.

A fluid scene without an explicit joint selector assigns the finalized joint topology to MuJoCo before solver construction. This allows the current DexUni/DFSPH prototype to advance the Franka and free cup together while preserving explicit selectors. The task sends both gripper finger targets, avoiding a missed grasp after the newer Gym action-selection changes.

The cup keeps separate rigid-contact hulls and a particle-only SDF boundary. On DexSim builds without NewtonCollisionDesc.contributes_to_mass, dynamic boundaries require explicit mass and inertia; the task authors the cup COM and inertia from its contact hulls. The FastRT liquid uses a compatible blue material. The Gym runner saves incomplete or rejected videos as diagnostics rather than qualifying them as accepted recordings.

Stack and dependencies

  • Target: main at e06a16477. PR Adapt DexSim 0.6 and consolidate DexUni two-way support #829 and PR Add basic fluid simulation and standalone tutorial #777 are merged.
  • The synchronized stack pins dexsim_engine==0.6.0rc1 and runs on Python 3.12 with CUDA on RTX 5090. Its DexUni/DFSPH composition supports isolated worlds and selected-world reset. The earlier 0.5.1 development-build task and performance qualification below remains historical.
  • Fluid coupling is one-way: rigid motion affects the liquid, but liquid forces do not feed back into the cup or robot. The native prototype requires a pure-MuJoCo rigid path when bodies are present and cannot combine fluid with cloth or soft particles.

Validation

  • 2026-11-11 run-task consolidation (fab037d34): moved measured cup/received-volume qualification and accepted particle-sidecar publication into the ordinary collection boundary, with row-selected 32 MiB spooling and unique artifact names. Removed run_fluid_task_program.py and its standalone tests; the Sim example now imports the shared physical measurement helper. A default 76,607-particle NoRender run passed with 756 control steps, 234.5 mL received, 11.9 cm lift, 79.8° tilt, 1.21 cm return error, and a 1.39 GB sidecar. That source completed full 756-step kinematic (maximum state error 3.1e-6) and dynamic replay. A final 3 mm recording with a unique file name and 178 MB sidecar passed qualification and full kinematic replay; FastRT produced exactly one accepted video after removing an initial-reset recording artifact. Focused replay/runner/camera tests passed (101), official task/config/expansion tests passed (253), context tests passed (42), Black 26.10.1, API coverage 4,832/4,832 and context check passed. The read-only Task Program inspector still rejects the existing fluid_object field in env.fluid.yaml; direct config decode and live execution passed. Context review revised the fluid replay overview and MAP ownership.

  • 2026-11-11 solver-config follow-up: e8028a153 removes the duplicate standalone-SPH check from native object conversion in cfg/physics.py. One normalization guard remains because DexSim registers sph as a named solver; removing it would reopen top-level solver_type=sph while named providers remain supported. The direct-provider bypass is covered by a new rejection test. The 122 relevant solver/config tests passed (1 skipped), Black 26.10.1 and API coverage 4,833/4,833 passed.

  • 2026-11-11 latest-main sync after standalone-SPH cleanup: merged origin/main at e06a16477 in cf719624c. Main's new test expected top-level solver_type=sph to pass through as a registered SDK solver; this conflicts with the fluid deployment's DexUni-only contract, so the explicit rejection regression was retained. The only content conflict in runtime-control tests was resolved using the unknown-capability fallback fixture. The combined branch passed 106 focused fluid/runtime tests, 42 context tests, Black 26.10.1 and API coverage 4,833/4,833.

  • 2026-11-11 standalone-SPH cleanup: commit 7d3d9f572 removes the remaining direct production construction of SPHSolverCfg, obtains fluid defaults through DexUniSolverCfg(sph_cfg=...), and centralizes access to DexSim's prepared internal fluid component behind the DexUni backend. Positive runtime/config tests now configure fluid only through DexUni. Public solver_type=sph and a direct top-level SPHSolverCfg remain explicitly rejected, with a negative regression test; the native SDK still names DexUni's internal fields sph_cfg and sph_solver. After rebasing onto the latest pour cleanup, 100 focused CPU tests, 3 native CUDA fluid lifecycle tests, 42 context tests, the fluid deployment inspector, Black 26.10.1, context validation and API coverage 4,833/4,833 passed.

  • 2026-11-11 DexUni-only capability cleanup (07af65fe5): fluid setup no longer loads the standalone SPH runtime to decide whether batched worlds are supported. After scene preparation and before the first physics step, it checks world isolation and selected-world reset on the prepared DexUni fluid component. The native nested sph_cfg and internal sph_solver remain; direct solver_type: sph stays rejected. On the current PR head, 94 focused CPU fluid/Replay tests, 6 native GPU fluid isolation/runtime/visibility cases, and 42 context tests passed. Black 26.10.1 left 2,463 files unchanged, API coverage is 4,833/4,833, and context validation passed. The existing unified Replay modes and the merge from main were retained.

  • 2026-11-11 latest-main sync after unified replay: merged origin/main at 02d0fda91 in commit 24ddaaf58. The only content conflict was the adjacent SimulationManager runtime-control methods; both the DexUni kinematic rigid-trajectory registration and main's joint DC motor registration were retained. The merged branch passed 73 focused fluid/replay tests, 42 context tests, 4 joint-motor registration tests, one native GPU fluid-boundary/reset regression, the fluid deployment inspector, Black 26.10.1, context validation and API coverage 4,833/4,833. GitHub reports the PR mergeable; remote CI checks are pending.

  • 2026-11-11 unified fluid replay: commit 65e437dde adds 32 MiB-per-row content-verified particle-state chunks, arena-local coordinates and pre-World qualification checks. A real one-environment FastRT pour passed physical acceptance and recorded 751 control steps with a 1.3 GiB sidecar; full kinematic and dynamic CLI replays both completed 751 steps. A real frame-200 kinematic particle check had zero position/velocity error, and a 10-step dynamic check wrote fluid state only at reset before DexUni evolved the particles. Focused validation passed 73 replay/fluid/runner tests, 42 context tests, static deployment inspection, Black 26.10.1 and API coverage 4,777/4,777. Representative four-environment I/O (76,607 particles, 747 frames per row) stored 5.49 GB, wrote in 7.65 s and read sequentially in 3.83 s with 220 MiB peak process RSS; this is a synthetic I/O measurement with possible filesystem cache effects, not an isolated solver benchmark. The recorded real run took 117.75 s wall time. An unrecorded baseline was stopped because other GPU jobs contended for the device, so no recording-overhead claim is made. Local evidence is under outputs/unified-fluid-replay-source-20261111/ and outputs/unified-fluid-replay-io-benchmark-20261111/. Follow-up bc2618e1c scopes the recorder to one published trajectory: it detaches after saving and rejects post-finalization capture so a later reset cannot delete referenced sidecars. The 23 directly affected tests, Black 26.10.1 and API coverage 4,833/4,833 passed after rebasing onto the newer fluid capability fix.

  • 2026-11-11 root-cause fix and four-environment qualification: the 1,056-step reference had no visible table splash with the same 1/240 s outer physics step and two DFSPH substeps. The shortened 670-step run completed the nominal three-second tilt segment but its moving trajectory reached the poured pose early and spent the remaining frames holding there. Two four-environment physics-step controls (four substeps, or 1/480 s with 12 physics steps per control) still splashed and reduced mean received volume to 110.0 and 106.4 mL respectively; a smaller solver step was not the remedy. The fix stretches the moving joint trajectory when rotation_duration exceeds its native duration. With the unchanged six physics steps per 25 ms control update, four FastRT environments at 1.5 mm and 76,607 particles each all passed every segment and physical acceptance: 746 task steps/18.65 simulated seconds, versus 670/16.75 in the splashing variant and 1,056/26.4 task seconds in the reference. Received volume was 170.72–171.23 mL (mean 170.98), maximum tilt 67.59–67.64°, and return error 1.66–1.79 mm. The synchronized four-view recording shows no conspicuous liquid spilled across the table; fluid speed settles after the pour. One-run wall time was 329.2 s. Validation: 10 focused Pour tests (including midpoint motion regression), 42 context tests, static deployment inspection, Black 26.10.1, API coverage 4,778/4,778, and context validation. The report and 18.675 s four-view video are local under outputs/pr790-true-4s-tilt-four-20261111/. This qualifies DexSim development build 0.6.0+88ac9206e0cb9c7894df6c7780f3e157806f0239, not published rc1.

  • Earlier 2026-11-11 slower-pour qualification after main sync (superseded): merged main at d95a5f161 and retained both the fluid runtime controls and main's joint initialization controls; direct standalone sph remains rejected. On RTX 5090, Python 3.12 and DexSim development build 0.6.0+88ac9206e0cb9c7894df6c7780f3e157806f0239, the complete four-environment FastRT Task Program passed all segments and physical acceptance in every row at 1.5 mm with 76,607 particles per environment. PourOptions.rotation_duration requests at least three seconds for each tilt and return, giving 121 and 120 frames versus 80 and 80 in the fast variant. Task execution was 670 steps/16.75 simulated seconds versus 563 steps/14.075 seconds; the 40 fps recordings have 671 frames. Received volume was 115.89–132.67 mL (mean 120.27 mL versus fast variant mean 111.61 mL); return error was 1.52–1.60 mm. Visible splashing remains. One-run measured wall time was 282.0 s versus 237.6 s. Focused validation passed: 414 simulation/config tests (7 skipped), 27 Pour skill/integration tests, 22 task/package tests, 42 context tests, 11 API-doc tests, static fluid deployment inspection, Black 26.10.1, API coverage (4,778/4,778), context validation and Sphinx dummy build with existing warnings. The report and synchronized four-view video are local under outputs/pr790-slower-pour-main-sync-four-env-20261111/. This qualifies the cited development build, not published rc1.

  • Earlier 2026-11-11 fast four-environment qualification (superseded): on RTX 5090, Python 3.12 and DexSim development build 0.6.0+88ac9206e0cb9c7894df6c7780f3e157806f0239, the complete four-environment FastRT Task Program passed all segments and physical acceptance in every row at 1.5 mm with 76,607 particles per environment. Control remains six 1/240 s physics steps per 25 ms update. The task used 563 steps and 14.075 simulated seconds versus 1,056 steps and 28.4 seconds before (50.4% less physical time); videos have 564 versus 1,137 frames at 40 fps. Lift was 120.97–121.03 mm, tilt 69.32–69.37°, return error 1.57–1.59 mm, and received volume 106.89–119.66 mL. One-run measured wall time was 237.6 s versus 504.5 s, not an isolated solver benchmark. The fluid-only franka_panda_fast_fluid component uses finger max effort 160 and dynamic friction 3.0; the original Franka joint speed caps and ordinary Newton embodiment remain unchanged. Static inspection for both deployments, 22 focused tests, 42 context tests, Black 26.10.1, API coverage (4,754/4,754), and context validation passed. The report and four recordings are local under outputs/pr790-four-env-physical-half-20261111/. This qualifies the cited development build, not published rc1.

  • Earlier control-step-only trial (superseded): on the same RTX 5090/Python 3.12/DexSim development build 0.6.0+88ac9206e0cb9c7894df6c7780f3e157806f0239, the full four-environment Task Program again completed all four segments and passed physical acceptance in every row at 1.5 mm and 76,607 particles per environment. Task control steps fell from 1,056 to 533 (49.5% fewer); each FastRT recording fell from 1,137 frames at 40 fps to 574 frames at 20 fps. Simulated duration remained 28.4–28.7 s. Measured received volume was 145.38–147.88 mL, lift 119.35–119.36 mm, maximum tilt 63.45–63.90°, and return error 3.21–3.58 mm. One-run wall time was 497.5 s versus the previous 504.5 s; no wall-time speedup is claimed. The four-view video and report are local under outputs/pr790-four-env-half-steps-20261111/. Static deployment inspection and 22 related tests passed; Black 26.10.1 left 2,401 files unchanged, API coverage was 4,754/4,754, and context validation passed.

  • 2026-11-11 full four-environment pouring qualification: on RTX 5090 with Python 3.12 and DexSim development build 0.6.0+88ac9206e0cb9c7894df6c7780f3e157806f0239, the configured Task Program completed all four segments (pick_cup, aim_cup_above_bowl, pour_water, return_cup) in all four environments and passed measured physical acceptance for every row. At the task default 1.5 mm spacing there were 76,607 particles per environment. Each environment simulated 28.4 s; the full run took 504.5 s wall time and produced four 960x720 FastRT recordings at 40 fps. Measured lift was 120.79–120.80 mm, maximum tilt 63.47–63.49°, return error 2.09–2.11 mm, and received volume 145.16–145.69 mL. The run report and a synchronized four-view video are retained locally under outputs/pr790-four-env-full-20261111/. This qualification applies to the cited development build; published dexsim_engine==0.6.0rc1 was not run in this four-environment acceptance pass.

  • 2026-11-11 main sync and preview: merged origin/main at 33a81cd25, resolved four overlaps in API docs and tests, and migrated the two Franka firm-grip embodiments to the current declared gripper binding. Fixed the runner report task path after recording. Three pour-cup deployments passed static inspection; 280 focused tests passed (4 skipped), 42 context tests and 11 API documentation tests passed. Black 26.10.1 left 2,401 files unchanged; API coverage is 4,754/4,754; context validation and Sphinx dummy build passed. A four-environment FastRT preview ran for 2.05 simulated seconds at 3 mm spacing with 9,778 particles per environment, producing four 960x720, 40 fps diagnostic videos and a local 2x2 preview. The run stopped during pick_cup by the requested preview duration, so it is not a physical acceptance result.

  • 2026-11-10 main sync: merged origin/main at 981894847 into Add pouring tasks, fluid replay and DexUni DFSPH prototype #790 and resolved the overlapping fluid changes and Atomic Skill rename conflicts. 700 focused CPU tests passed (3 skipped), 224 Atomic Skill example tests passed (2 skipped), all three configured deployments passed static inspection, and 5 serial native GPU fluid checks passed. Black left 2,324 files unchanged; API coverage was 4,691/4,691; 42 context tests, context validation and Sphinx dummy build passed. The full pouring Task Program physical acceptance run was not repeated.

  • 2026-11-09 target sync: merged codex/adapt-latest-dexsim at c6e991c2 (including merged Add basic fluid simulation and standalone tutorial #777 at e14fc4e78) and resolved seven overlapping fluid conflicts. All three configured deployments passed static inspection; 700 focused CPU tests passed (3 skipped), 42 context tests and 11 API documentation tests passed, and 5 serial native GPU checks passed for online fluid, selected-world reset, diagnostic replay and camera visibility on DexSim 0.6.0rc1. Black left 2,322 files unchanged; API coverage is 4,457/4,457; context validation and the Sphinx dummy build passed with existing documentation warnings. The full Task Program physical acceptance run was not repeated on 0.6.0rc1.

Earlier qualification on the DexSim 0.5.1 development build:

  • Full FastRT Task Program, one environment, 1.5 mm spacing and 76,607 particles: all four segments and physical qualification passed. The new 960×720, 40 fps recording is 28.475 s versus 43.75 s for the previous policy. Measured lift 120.4 mm, maximum tilt 63.4°, return error 2.2 mm and received volume 144.9 mL (previously 160.1 mL; acceptance requires at least 50 mL).
  • The standalone DexUni Atomic Action demo completed a full four-environment FastRT run in one World, at 1.5 mm particle spacing and 76,607 particles per environment. All four passed physical qualification: each received 139.7–140.1 mL, lifted 126.5 mm, tilted 62.6°, and returned within 4.4 mm. Each camera recorded 26.5 s of simulation at 40 fps; the measured end-to-end run took 512.8 s on the RTX 5090. The robot and fluid were solved online.
  • Serial GPU checks passed for DexUni fluid lifecycle, isolated multi-world reset, dynamic boundary motion and mass/inertia, robot mimic handling, Gym partial reset, diagnostic replay, and FastRT camera visibility. The online test was rerun after updating its DexUni configuration.
  • Static deployment inspection passed for the fluid, Newton and default Franka variants. Selected CPU suites passed 582 tests; an additional overlapping backend/manager selection passed 250 tests. The full suite was not run.
  • For the shortened policy, the fluid deployment inspector and 130 configuration, package-staging and task-runner tests passed; package staging resolves the fluid deployment and its new policy from installed paths.
  • black . ran with 26.3.1 and 26.10.1; API coverage is 3300/3300, agent context checks pass, and task discovery lists pour_cup.
  • The full Task Program was qualified for one environment. The separate Atomic Action demo was qualified for four environments, and two-environment isolation and reset were tested separately; a full multi-environment Task Program has not been qualified.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I ran black ..
  • I reviewed and updated affected agent context.
  • Public API documentation coverage passes.
  • Appropriate behavioral coverage and test necessity were reviewed.
  • Dependencies were checked against the pinned DexSim 0.6.0rc1 build.

xiemenghong and others added 30 commits September 17, 2026 09:48
Migrate DexUni example settings to the current namespaced solver interface and preserve the existing cloth contact values. Update the Newton config regression test and document the new mapping contract.
Port the retained MJVBD V2 integration consumers to the current DexUni public interface, while keeping AutoSolver as the Newton default. Preserve namespaced solver options, tutorial calibration, reset/mimic handling, and current task configuration.
Allow geometry-only ContactQuery data for DexUni VBD paths and full impulse/friction data for pure MuJoCo. Add capability tests and GPU end-to-end coverage.
…e-adaptation

# Conflicts:
#	embodichain/lab/sim/cfg/simulation.py
#	tests/sim/test_cfg.py
Add typed fluid scene ownership, observations and row-local refill; gate batching on native SPH capabilities. Generate and qualify the pouring Task Program in MuJoCo before replaying measured states in an independent SPH Gym. Package physical assets and keep source acceptance separate from fluid metrics. Requires DexSim world-isolated SPH support (d2d36fbcb) for batched scenes.
Use Hybrid by default with FastRT support, and route replay videos through the configured record_camera event. Add separate environment buffers, selected save/discard and configurable cadence to record_camera_data. Explicitly commit the final replay recording. Qualified two complete 744-frame Hybrid videos, both renderer smoke runs, row-local recording reset, 128 focused tests and the live Gym reset regression.
Sample a declared capped revolved profile and fill level on a deterministic lattice. Keep solid clearance separate from the free surface and retain the local template in memory for reset. Remove the default water_fill particle asset, resample the same recipe for spacing overrides, and preserve explicit point imports. Qualify complete two-environment Hybrid pouring and per-environment recordings.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yuecideng
yuecideng marked this pull request as ready for review November 9, 2026 06:54
@greptile-apps

greptile-apps Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The changes add fluid simulation and recording paths to the shared environment and simulation APIs.

Require kinematic robot playback before merging; the bounded-run measurement issue is non-blocking.

Fix All in CodexFindings

  1. P1 Drives fight replayed motion ▶
  2. P2 Diagnostics miss the final pose ▶
Fix with agent prompt
### Issue 1
embodichain/lab/gym/envs/fluid_replay.py:126-131
`FluidReplayEnv` accepts `joint_mode: dynamic`, but playback only writes the robot's current positions and velocities. Reset leaves the drive targets at the first recorded pose. Each physics step can then pull the robot toward that pose instead of following the recording, changing both the robot motion and the boundaries seen by the liquid.

Require a compatible kinematic configuration before creating the scene, or explicitly set up kinematic joint playback.

### Issue 2
embodichain/lab/scripts/run_fluid_task_program.py:159-161
During a bounded `--seconds` run, `execute_demo_episode()` stops and closes this iterator without resuming past `yield action`. The last completed step's pose is never captured. Incomplete runs also skip settling, so `_cup_qualification()` reports the previous step's return error and can miss the largest lift or tilt.

Capture the final measured pose after execution returns, including interrupted runs.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Adds online cup-pouring tasks, a standalone DexUni demonstration, and diagnostic fluid replay.

  • DexUni scenes can advance rigid bodies and fluid particles together.
  • The Franka Task Program picks up a cup, pours water, and returns it.
  • Qualified pour recordings can replay rigid motion while fluid simulation continues.
  • Camera videos use the control rate and capture the current scene view.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Config[Pouring configuration] --> Env[EmbodiedEnv]
  Env --> Targets[Task Program joint targets]
  Targets --> Rigid[Robot and cup physics]
  Rigid --> Fluid[One-way DFSPH fluid]
  Fluid --> Measures[Volume and cup measurements]
  Env --> Video[Current camera frames]
  Measures --> Report[Qualification report]
  Recording[Accepted historical recording] --> Replay[FluidReplayEnv]
  Replay --> Rigid
Loading

Reviews (1) · Last reviewed commit: "chore(fluid): include latest target docu..." · Reviewed by Greptile

Comment on lines +126 to +131
if not isinstance(physics, NewtonPhysicsCfg) or solver_type != "dexuni":
raise ValueError("Fluid replay requires Newton DexUni with DFSPH.")
if cfg.sim_cfg.physics_cfg.num_substeps != 1:
raise ValueError(
"Fluid Gym replay requires num_substeps=1; choose physics_dt for boundary cadence."
)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Drives fight replayed motion

FluidReplayEnv accepts joint_mode: dynamic, but playback only writes the robot's current positions and velocities. Reset leaves the drive targets at the first recorded pose. Each physics step can then pull the robot toward that pose instead of following the recording, changing both the robot motion and the boundaries seen by the liquid.

Require a compatible kinematic configuration before creating the scene, or explicitly set up kinematic joint playback.

Prompt To Fix With AI
This is a comment left during a code review.
Path: embodichain/lab/gym/envs/fluid_replay.py
Line: 126-131

Comment:
**Drives fight replayed motion**

`FluidReplayEnv` accepts `joint_mode: dynamic`, but playback only writes the robot's current positions and velocities. Reset leaves the drive targets at the first recorded pose. Each physics step can then pull the robot toward that pose instead of following the recording, changing both the robot motion and the boundaries seen by the liquid.

Require a compatible kinematic configuration before creating the scene, or explicitly set up kinematic joint playback.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Codex Fix in Claude Code

Comment on lines +159 to +161
for action in actions:
yield action
poses.append(cup.get_local_pose().cpu().numpy().copy())

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Diagnostics miss the final pose

During a bounded --seconds run, execute_demo_episode() stops and closes this iterator without resuming past yield action. The last completed step's pose is never captured. Incomplete runs also skip settling, so _cup_qualification() reports the previous step's return error and can miss the largest lift or tilt.

Capture the final measured pose after execution returns, including interrupted runs.

Prompt To Fix With AI
This is a comment left during a code review.
Path: embodichain/lab/scripts/run_fluid_task_program.py
Line: 159-161

Comment:
**Diagnostics miss the final pose**

During a bounded `--seconds` run, `execute_demo_episode()` stops and closes this iterator without resuming past `yield action`. The last completed step's pose is never captured. Incomplete runs also skip settling, so `_cup_qualification()` reports the previous step's return error and can miss the largest lift or tilt.

Capture the final measured pose after execution returns, including interrupted runs.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Codex Fix in Claude Code

Base automatically changed from codex/adapt-latest-dexsim to main November 10, 2026 11:01
Move pour acceptance and particle sidecar publication into the ordinary Task Program collection boundary. Keep row-local spooling bounded, remove the standalone fluid runner, and update examples and project context.
Keep the fluid deployment as the single pour-cup entry. Remove the empty-cup environment, program, integration and their exclusive embodiment and execution policy. Update packaging expectations, hand-binding coverage and task documentation.

Validation: 57 targeted tests passed; the retained deployment inspector and production task catalog passed.
Context: no update needed; existing component ownership and fluid workflow guidance remain accurate.
Integrate main at fcca082, preserving fluid sidecars, generic collection qualification, and main's physical evaluation and managed expert-source support. Resolve six overlapping files without restoring removed helper modules or the empty-cup deployment.
@yuecideng
yuecideng merged commit 97bd244 into main Nov 12, 2026
10 of 12 checks passed
@yuecideng
yuecideng deleted the feat/dexuni-fluid-prototype branch November 12, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assets Robot and scene assets, meshes, materials, asset catalogs and downloads. data-pipeline Data collection, ODS, sampling, recording, persistence, conversion and analysis. dexsim DexSim SDK interfaces, version adaptation and integration. docs Documentation, API references and example explanations. feature New user-facing capabilities. gym Environment lifecycle, managers, configuration composition and registration. physics Physics backends, dynamics, contacts, fluids, deformables and physics solvers. task Concrete tasks, deployments, objectives and recipes, including configured Task Program tasks. task-program Task Program language, semantics, compiler, runtime and integration contracts.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants