Repository navigation
Register CableObject facades for USD cables #1171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
0a2b25f
fix(sim): register CableObject facades for USD cables
KeqiYe 40a8f52
Merge main and preserve cable registration during USD preflight
KeqiYe f2be8ea
feat(sim): support sparse physics overrides on USD cables
KeqiYe 85f25b4
test(gym): exercise USD cable overrides through scene preflight and r…
KeqiYe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Resolve attachment targets before validating the renamed cable
A valid source cable
wireattached to rigid objectbasefails when these overrides reuse the rigid object's original name:The final UIDs are unique and the intended connection is cable
base-> rigidanchor. However,_usd_cable_cfg()changesdescriptor.nametobaseand callsCableDesc.__post_init__()whilestart_attachment.targetstill contains the old namebase. The SDK raisesValueError: a cable cannot attach to itselfbefore target remapping at lines 646-660 can run. Bothadd_usd()and Gym's manager-free preflight reject this valid configuration.Reproduced with a real parsed USD under DexSim 0.6.0rc2, with the cable endpoint and rigid anchor both at world [0, 0, 0]. Renaming the cable to
renamed_wiresucceeds and producesrenamed_wire->anchor; changing only that UID tobasecauses the error.Please validate attachment relationships after all final UIDs and attachment targets have been resolved, while retaining early validation of geometry and fixed indices. A focused no-simulation regression for this valid UID-reuse case would cover the gap.