Repository navigation
Restrict GenSim profile credentials to the service origin - #1137
Merged
Merged
Conversation
yuecideng
approved these changes
Nov 10, 2026
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Geometry reconstruction can return an absolute mesh URL on another host. HTTP profiles previously placed the service Bearer token in the shared session headers, so downloading that mesh also sent the token to the file host. The HTTP profile session now attaches the token only when the request scheme, host and effective port match the configured service origin, and strips authorization on redirects to another origin, including same-host HTTP-to-HTTPS redirects.
This fixes the credential-forwarding finding on #837. The affected service code is already on main, so the fix can be reviewed and merged independently of the RL task changes.
Type of change
Validation
pyrender; the installed-wheel CLI check also encountered that missing dependency.black .with Black 26.10.1 passed.python docs/scripts/check_api_docs.pypassed: 4437/4437 exports documented.Asset download reliability
The shared dataset loader now appends the official Hugging Face source for known EmbodiChain asset URLs on hf-mirror.com. A failed mirror download falls through to the same asset path and revision with the original checksum and extraction settings. Custom hosts and unrelated repositories retain their declared sources.
This addresses the asset-download failure in #1154 CI. The identical repair is included in #837, #1137 and #1154. Validation on #1154: 154 data tests passed, including seven fallback cases; the original contact-sensor test passed. An empty-cache download reproduced the mirror SSL failure and then downloaded, verified and extracted the asset from the official source. The data-assets context documents this behavior. Full Actions checks for the new commits are pending.
Checklist
black .command to format the code base.python docs/scripts/check_api_docs.py), if applicable.