Skip to content

Restrict GenSim profile credentials to the service origin - #1137

Merged
yuecideng merged 6 commits into
mainfrom
codex/gensim-origin-auth
Nov 15, 2026
Merged

yuecideng merged 6 commits into
mainfrom
codex/gensim-origin-auth

Conversation

@acrlw

@acrlw acrlw commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Geometry reconstruction can return an absolute mesh URL on another host. HTTP profiles previously placed the service Bearer token in the shared session headers, so downloading that mesh also sent the token to the file host. The HTTP profile session now attaches the token only when the request scheme, host and effective port match the configured service origin, and strips authorization on redirects to another origin, including same-host HTTP-to-HTTPS redirects.

This fixes the credential-forwarding finding on #837. The affected service code is already on main, so the fix can be reviewed and merged independently of the RL task changes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Validation

  • 59 selected service/client tests passed, including seven transport regressions for service-relative URLs, equivalent default ports, external URLs, different ports, cross-origin redirects and same-origin redirects.
  • The selected suite excluded the legacy SimReady import case because the minimal validation environment lacks optional pyrender; the installed-wheel CLI check also encountered that missing dependency.
  • black . with Black 26.10.1 passed.
  • python docs/scripts/check_api_docs.py passed: 4437/4437 exports documented.
  • Updated the service README. Existing GenSim agent context still accurately describes transport and authentication ownership.

Asset download reliability

The shared dataset loader now appends the official Hugging Face source for known EmbodiChain asset URLs on hf-mirror.com. A failed mirror download falls through to the same asset path and revision with the original checksum and extraction settings. Custom hosts and unrelated repositories retain their declared sources.

This addresses the asset-download failure in #1154 CI. The identical repair is included in #837, #1137 and #1154. Validation on #1154: 154 data tests passed, including seven fallback cases; the original contact-sensor test passed. An empty-cache download reproduced the mirror SSL failure and then downloaded, verified and extracted the asset from the official source. The data-assets context documents this behavior. Full Actions checks for the new commits are pending.

Checklist

  • I have run the black . command to format the code base.
  • I reviewed affected documentation and agent context, updated it where needed, or explained why no update was needed.
  • Public API changes are reflected in the API docs (python docs/scripts/check_api_docs.py), if applicable.
  • I verified appropriate behavioral coverage and reviewed the necessity of added or extended tests.
  • Dependencies have been reviewed; no changes are required.

@acrlw acrlw added bug Incorrect existing behavior or a fix restoring the intended behavior. gen-sim Scene Engine generation and editing, scene export and SimReady pipelines. labels Nov 10, 2026
@yuecideng
yuecideng merged commit 431c497 into main Nov 15, 2026
8 checks passed
@yuecideng
yuecideng deleted the codex/gensim-origin-auth branch November 15, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Incorrect existing behavior or a fix restoring the intended behavior. gen-sim Scene Engine generation and editing, scene export and SimReady pipelines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants