refactor(winrm): delete dead AnyTag/TagList and stale tag markers#35
Merged
irvingouj@Devolutions (irvingoujAtDevolution) merged 3 commits intoJun 25, 2026
Conversation
`Tag<Tag<W, M>, N>` (e.g. `command_response: <CommandResponse><CommandId/>`,
`signal: <Signal><SignalCode/>`) models an N element wrapping a single M child.
The new FromXml passed the parent node straight to the inner tag's from_xml,
which then checked the wrapper's name and failed
("Invalid tag: expected 'CommandId', found 'CommandResponse'").
Tag::from_xml now descends to the single N-named child when handed a node that
isn't itself N — restoring the old from_children semantics for nested tags.
This only surfaced on SSPI auth (Negotiate/Kerberos/NTLM), which exchanges
CommandId; Basic never hits that path, so unit fixtures missed it. Added a
unit regression test for the nested CommandResponse/CommandId shape.
Verified: real-server transport×auth×sealing matrix now 10/10 (was 4/10 on
this branch; master is 10/10). fmt + clippy + workspace tests all clean.
…a NamedTag Two steps toward de-uglifying the Tag layer, both behavior-preserving: 1. `NamedTag` trait: exposes a tag's (TAG_NAME, NAMESPACE) at the type level, forwarding from `N: TagName`. `#[derive(FromXml)]` now reads identity via `<FieldType as NamedTag>` instead of syntactically extracting the `N` param — so it will keep working once fields become type aliases for `Tag<'a, V, N>`. 2. Delete `AnyTag` + `TagList`: the dynamic heterogeneous-list escape hatch. `TagList::with_tag` was never called (never built with content), its ~45 AnyTag variants were dead (SOAP envelope/header/body are typed structs now; the PSRP CLIXML tags belong to ps_value), and the four `Tag<TagList, _>` bodies on SoapBody (pull/release/get_status/command) were never populated and only checked for `.is_none()` in tests. Removed the fields, the two files, and the stale test assertions. Verified: workspace tests pass; real-server matrix 10/10.
With AnyTag gone, ~22 TagName markers had no remaining referent: the PSRP CLIXML set (Obj, MS, TN, T, S, B, Nil, DCT, En, Key, Value, ToString, I32TagName, BA, Version), the InitRunspacepool set (MinRunspaces, MaxRunspaces, PSThreadOptions, ApartmentState, HostInfo, ApplicationArguments — ps_value's job), and FaultTo / From / FragmentTransfer. Removed. Workspace compiles, so nothing referenced them.
This was referenced Jun 25, 2026
irvingouj@Devolutions (irvingoujAtDevolution)
changed the base branch from
stack/xml-fromxml-nested-fix
to
master
irvingouj@Devolutions (irvingoujAtDevolution)
deleted the
stack/xml-fromxml-rm-deadcode
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3/6. Base:
stack/xml-fromxml-nested-fix.Deletes the now-dead
AnyTag/TagListtypes and the tag-name markers orphaned by their removal. The derive reads identity through theNamedTagtrait (alias-friendly). Pure deletion + trait plumbing; no wire-format change.FromXml stack (review/merge bottom-up):
tag!macro + aliases