refactor (pool 5/N): group inbound message handling into incoming.rs#29
Merged
irvingouj@Devolutions (irvingoujAtDevolution) merged 3 commits intoJun 23, 2026
Conversation
…n into host_call.rs Move the pure PipelineHostCall parsing and the needs-session-key classification out of pool.rs into a new private runspace_pool::host_call module (named to avoid collision with crate::host). Fragmentation-coupled send + the pending_host_calls queue stay in the pool. Behavior-preserving.
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
stack/09-pool-extract-wire
branch
from
ec8b445 to
95f4470
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
stack/10-pool-extract-incoming
branch
from
a96021d to
0a6d57c
Compare
…equests.rs Split the eight outbound-request methods (fire_receive/disconnect/reconnect, kill_pipeline, invoke_spec, send_pipeline_host_response, send_runspace_pool_message, build_public_key_blob_base64) out of pool.rs into a sibling requests.rs via a split impl RunspacePool block. Collects all &self.connection (WsMan) usage in one place as groundwork for a future transport seam. pool.rs 2029 -> 1594 lines; behavior-identical.
Split the inbound server-response / PSRP message-handling methods (accept_response, handle_pwsh_responses + its per-message handlers, handle_session_capability, handle_application_private_data, handle_pipeline_host_call/output, accept_disconnect/ reconnect_response, fault helpers) out of pool.rs into a sibling incoming.rs via a split impl RunspacePool block. Mirrors requests.rs (outbound); groundwork for a future event-driven on_message API. pool.rs ~1800 -> ~660 lines; no visibility widening; behavior-identical.
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
stack/10-pool-extract-incoming
branch
from
0a6d57c to
1aa31fa
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
force-pushed
the
stack/09-pool-extract-wire
branch
from
95f4470 to
886d91f
Compare
irvingouj@Devolutions (irvingoujAtDevolution)
changed the base branch from
stack/09-pool-extract-wire
to
master
irvingouj@Devolutions (irvingoujAtDevolution)
deleted the
stack/10-pool-extract-incoming
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #28. Fifth step of decomposing the
RunspacePoolgod-object.Splits the inbound server-response / PSRP message-handling out of
pool.rsinto a siblingincoming.rsvia a splitimpl RunspacePoolblock — mirror ofrequests.rs(outbound):accept_response+handle_pwsh_responsesand its per-message handlers,handle_session_capability/handle_application_private_data,handle_pipeline_host_call/_output,accept_disconnect/reconnect_response, fault helpers.pool.rs~1800 → ~660 lines. Behavior-identical; clippy clean, tests green.Groundwork for a future event-driven
on_messageAPI (inbound dispatch now isolated).Reviewed: Benoit-style pass (nit fixed:
mod.rsordering) + Codex pass (NO_ISSUES_FOUND).