Skip to content

Should look for nodes with alternate component version when looking for chidren #146

Description

@mvoica

const renderedChildren = getRenderedChildren(reactComponent);

could this line be something like

var renderedChildren = getRenderedChildren(getRenderedComponentVersion(reactComponent, getRootElsReact16()));

?

or well, could the children be looked at in the context of the component.alternate (?)

The getRenderedComponentVersion is already called when we look for the component corresponding to a certain dom node (which is where the search for children starts):

return getRenderedComponentVersion(reactInstance, rootInstances);

but we never look at the component.alternate during the search for nested children

Came across this when trying to access the children of a component that is wrapped by the react-i18next@7.8.3 translate(Component) wrapper, when doing some .findReact(A).findReact(B).findReact(C). In which case, one of the intermediate components has no child, but its alternate does have the child with which the search should continue.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions