Conversation
…tes (#2311) The comment on CBM_EXTRACT_BUDGET called it a "maximum byte budget", but every call site passes it as cbm_extract_file*()'s timeout_micros, which cbm.c converts to nanoseconds and uses as a per-thread CPU-time deadline (5 s) with a 12x wall-clock ceiling as a backstop for a stuck parse. No code path uses the value with the wrong unit; only the documentation was wrong. Correct the constant's comment, and bring the timeout_micros description in cbm.h up to date (CPU time + wall backstop, not a plain timeout) and back onto cbm_extract_file(), from which later additions had separated it. No behavior change; the budget value is unchanged. Reported-by: BobbieBarker Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBM_EXTRACT_BUDGETwas described as a "maximum byte budget", but every call site passes it ascbm_extract_file*()'stimeout_micros: a per-file tree-sitter parse budget in microseconds of the parsing thread's CPU time (5 s), with a 12× wall-clock backstop (cbm.c). This corrects that comment and thetimeout_microsdescription ininternal/cbm/cbm.h, and moves the latter back ontocbm_extract_file().Comments only; no behaviour or value change.
make -f Makefile.cbm lint-cipasses. The optional rename of the constant is left out to keep the change small.Thanks to @BobbieBarker for the report.
Fixes #2311