chore: Add workflow to update major version tag on release - #939
Merged
Merged
Conversation
DenverCoder1
temporarily deployed
to
streak-stats-denvercode-jexuey
September 17, 2026 10:17
Inactive
Removed comments for clarity and conciseness.
DenverCoder1
temporarily deployed
to
streak-stats-denvercode-jexuey
September 17, 2026 10:18
Inactive
DenverCoder1
temporarily deployed
to
streak-stats-denvercode-jexuey
September 17, 2026 10:21
Inactive
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Critical security and tag-consistency issues, plus moderate release-handling issues, remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a GitHub Actions workflow to update floating major-version tags when releases are published.
Changes:
- Triggers on published releases.
- Parses semantic version tags.
- Creates or force-updates the corresponding major tag.
- Grants permission to push tags.
File summaries
| File | Summary | Review findings |
|---|---|---|
.github/workflows/update-major-version-tag.yml |
Adds release-triggered major-version tag management. | Critical shell-injection and concurrent-update risks; moderate prerelease and invalid-tag handling issues. |
Review details
Suppressed comments (3)
.github/workflows/update-major-version-tag.yml:59
- This is a second direct interpolation of the untrusted release tag into shell code. A malicious tag can execute commands before
git rev-listruns; reuse a step environment variable instead of embedding the expression inrun.
.github/workflows/update-major-version-tag.yml:34 - The diagnostic says the update is being skipped, but
exit 1fails the job. A manually created release with a non-semver tag will therefore report a failed workflow rather than leave the major tag unchanged; either add an explicit skip path for the remaining tag-update steps or make the message describe the intentional failure.
# Preserve the "v" prefix convention if the release tag used one.
if [[ "$tag" == v* ]]; then
.github/workflows/update-major-version-tag.yml:17
- The
publishedevent also fires for prereleases, and this condition does not exclude them. Publishingv1.2.3-rc.1will therefore move the stablev1alias to prerelease code; excludegithub.event.release.prereleaseif this tag is intended to serve stable consumers.
with:
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
DenverCoder1
temporarily deployed
to
streak-stats-denvercode-jexuey
September 17, 2026 10:25
Inactive
DenverCoder1
temporarily deployed
to
streak-stats-denvercode-jexuey
September 17, 2026 10:30
Inactive
Change concurrency setting to cancel in-progress updates.
DenverCoder1
temporarily deployed
to
streak-stats-denvercode-jexuey
September 17, 2026 10:38
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #938
Type of change
How Has This Been Tested?
composer testChecklist:
Screenshots