Skip diff_html for photo actions#2757
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
Photo upload / approve / reject / ignore actions don't write Person versions (the photo lives on the moderation queue), so the lookup in diff_html raised VersionNotFound and the 'Recent edits' table on /accounts/me ended up showing 'Couldn't find version for person'. Just return an empty string for those action types - the action description column already says 'uploaded a photo of ...' so nothing useful goes missing. Closes DemocracyClub#2734 Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2734.
Photo
LoggedActionrows (upload / approve / reject / ignore) don't write a Person version - the photo flows through the moderation queue instead - soLoggedAction#diff_htmltriesperson.diff_for_version(popit_person_new_version), doesn't find anything, and rendersCouldn't find version for person with ID …in the 'Recent edits' table on/accounts/me.Return empty for those action types. The 'Action Type' / 'Edited' columns already describe what happened ('uploaded a photo of candidate #X'), so the Diff cell just being blank is the cleaner outcome.