WiP: More complicated fixture creation#2985
Open
GeoWill wants to merge 7 commits into
Open
Conversation
This is an initial scoping out of whether using factories to produce our test data is easier to maintain and introduce better coverage.
Really just an exercise to get a feel for writing tests with factories but always good to make coverage happier.
The aim of this class is to make it easier to define, maintain and reason about the multiple ways a postcode can exist in the db that we want to test for. The aim is that, combined with various factory classes that it depends on, it should replace a lot of the json fixtures which can become unwieldly to read and alter. This should also make it easier to understand what the tests are meant to be testing.
This is mainly to get a feel for/dmeonstrate the ergonomics of writing tests like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A home for work started in #2968