Red koopa shell: fix circling, add terrain step-up, clean homing algorithm#106
Draft
Copilot wants to merge 4 commits into
Draft
Red koopa shell: fix circling, add terrain step-up, clean homing algorithm#106Copilot wants to merge 4 commits into
Copilot wants to merge 4 commits into
Conversation
Co-authored-by: Hugman76 <36963654+Hugman76@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Revisit and improve algorithms for koopa shell behavior
Fix koopa shell bugs and improve homing/speed algorithms
Mar 1, 2026
Co-authored-by: Hugman76 <36963654+Hugman76@users.noreply.github.com>
Copilot
AI
changed the title
Fix koopa shell bugs and improve homing/speed algorithms
Fix koopa shell algorithms and bugs
Mar 1, 2026
…gorithm Co-authored-by: Hugman76 <36963654+Hugman76@users.noreply.github.com>
Copilot
AI
changed the title
Fix koopa shell algorithms and bugs
Red koopa shell: fix circling, add terrain step-up, clean homing algorithm
Mar 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Red koopa shells circled targets rather than hitting them, and were useless on any non-flat terrain.
Changes
Fix circling near targets
The P-controller gain was too low (
0.1), causing the shell to take ~10 ticks to align — enough to orbit close targets indefinitely. Raised to0.25via a named constantHOMING_TURN_RATE.Terrain step-up
Overrides
maxUpStep()returning1.0fso the shell uses Minecraft's built-in step-up physics to climb single blocks in its path — consistent with how players and mobs navigate terrain.Homing algorithm cleanup
currentVelocity.multiply(1, 0, 1)intocurrentHorizontal(was duplicated)length()→lengthSqr()(avoids unnecessarysqrt)== 0float equality with< 1e-10epsilon guard✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.