Skip to content

Fix test_thread_please_reaction_exists to use correct reaction name#14

Merged
alexeygrigorev merged 3 commits into
mainfrom
copilot/fix-thread-please-reaction-name
Jan 17, 2026
Merged

Fix test_thread_please_reaction_exists to use correct reaction name#14
alexeygrigorev merged 3 commits into
mainfrom
copilot/fix-thread-please-reaction-name

Conversation

Copilot AI commented Jan 17, 2026

Copy link
Copy Markdown
Contributor

The test was querying for thread_please (underscore) while the config defines thread-please (hyphen), causing the test to fail.

Changes:

  • Updated tests/test_automator_lambda.py line 246: reaction_configs.get('thread_please')reaction_configs.get('thread-please')
  • Updated docstring to match corrected reaction name

The config file (automator/config.yaml) correctly defines the reaction as thread-please to match Slack's emoji naming convention.

Original prompt

Problem

The test test_thread_please_reaction_exists is failing because it's looking for the wrong reaction name.

Actual Slack reaction: thread-please (with hyphen)
Test is looking for: thread_please (with underscore)

The config file correctly defines the reaction as thread-please to match the actual Slack reaction emoji, but the test file has an incorrect reference.

Solution

Update tests/test_automator_lambda.py to fix the test method test_thread_please_reaction_exists to look for thread-please instead of thread_please.

File to modify: tests/test_automator_lambda.py
Lines 244-253: In the test method test_thread_please_reaction_exists, change:

  • Line 246: reaction_config = lambda_function.reaction_configs.get('thread_please')
    • Change to: reaction_config = lambda_function.reaction_configs.get('thread-please')

This will align the test with the actual Slack reaction name and resolve the failing test.

This pull request was created from Copilot chat.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits January 17, 2026 20:21
Co-authored-by: alexeygrigorev <875246+alexeygrigorev@users.noreply.github.com>
Co-authored-by: alexeygrigorev <875246+alexeygrigorev@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix reaction name in test for thread-please Fix test_thread_please_reaction_exists to use correct reaction name Jan 17, 2026
Copilot AI requested a review from alexeygrigorev January 17, 2026 20:23
@alexeygrigorev alexeygrigorev marked this pull request as ready for review January 17, 2026 20:23
@alexeygrigorev alexeygrigorev merged commit 5103efb into main Jan 17, 2026
1 check passed
@alexeygrigorev alexeygrigorev deleted the copilot/fix-thread-please-reaction-name branch January 17, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants