Feature: feat/judge-nfc-tables to dev - #456
Merged
Merged
Conversation
Table cards keep their QR code; an NFC tag is an optional second way in. The tag holds the judge page URL with ?table=<code>. Tapping it opens the page (iPhone background read or Android) and, once judge access and an open round are confirmed, calls startByQrCode with that code: the same start, clock and wrong-table check as scanning the card. The param is removed after use so a reload does not replay it, and sign-in keeps the full URL, so a signed-out judge comes back to the table. Each table card gets Copy link (for writing tags from an NFC app) and, on Chrome for Android, Write NFC tag via Web NFC. Neither prints. The in-page scanner also accepts the link form of the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR tracking changes from
feat/judge-nfc-tablesintodev.Note
Low Risk
Frontend-only UX on the existing
startByQrCodepath; NFC writing is optional and browser-limited (Android Chrome).Overview
Adds tap-to-start for hackathon judging alongside the existing QR scan flow, without new server APIs.
On the judge page, opening
/hackathons/{id}/judge?table=<code>(e.g. from an NFC URL record) waits until the user is a judge and judging is open, then calls the existingstartByQrCodemutation, stripstablefrom the URL so reloads cannot replay, and updates copy to mention NFC. The QR scanner still accepts bare codes but can also parse a scanned URL and pulltablefrom the query string.In Table Cards (organiser UI), each card gets non-printing controls to write the judge deep link to a tag via Web NFC (Chrome/Android) or copy the same link for external writer apps, plus updated instructions on cards and in the header.
Reviewed by Cursor Bugbot for commit 3f668a1. Bugbot is set up for automated code reviews on this repo. Configure here.