Keep the URL hash when returning after login - #437
Merged
Merged
Conversation
Review follow-up to #426. loginHref built callbackUrl from pathname and search only, so the hash was dropped. /club and /hackathons pick their tab from it, so a shared or refreshed #history / #projects link came back to the default tab after sign-in. safeCallback already accepts fragments, and both the email-code and OAuth paths pass them through.
aamoghS
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR tracking changes from
fix/login-keep-hashintodev.Note
Low Risk
Small, localized change to login redirect construction with added tests; no changes to open-redirect guards in
safeCallback.Overview
loginHref()now preserves the URL hash when building the post-logincallbackUrl, so deep links like/club?x=1#historyno longer drop the fragment and land users on the default tab after sign-in.The change appends
window.location.hashalongside pathname and search. A new Vitest suite mockswindowto assert the encoded login URL and thatsafeCallbackstill accepts hash-bearing paths.Reviewed by Cursor Bugbot for commit 847e508. Bugbot is set up for automated code reviews on this repo. Configure here.