Hacklytics: countdown time, nav links on 404, mobile menu a11y - #431
Open
github-actions[bot] wants to merge 1 commit into
Open
github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
- The countdown targeted new Date("2027-02-26T23:59:59") with no offset,
which means midnight in each visitor's own timezone. Check-in opens at
5pm ET (the JSON-LD startDate), so ET visitors saw it keep running ~7h
after doors and PT visitors' target was ~3am ET Saturday.
- Navbar links always preventDefault'd, then bailed when the section was
not on the page: on the 404 page About/FAQ did nothing, and cmd/ctrl-
click could never open a new tab. They now fall through to normal
navigation in both cases.
- The closed mobile menu is hidden only by opacity, so its links sat in
the tab order and accessibility tree. It is now inert when closed, and
the toggle reports aria-expanded / aria-controls.
- MLH badge link: add rel="noopener noreferrer" like every other
external link.
- Remove public/index.html, Firebase's "Hosting Setup Complete"
boilerplate, which sits at the same path as the app's / page (next dev
reports the conflict; a copy-order change would ship it).
aamoghS
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new Date("2027-02-26T23:59:59")— no offset, so midnight in each visitor's own timezone. Check-in opens 5pm ET (the JSON-LDstartDate): ET visitors saw it run ~7h past doors; PT visitors' target was ~3am ET Saturday. Now2027-02-26T17:00:00-05:00.preventDefault'd, then bailed if the section wasn't on the page — on the 404 page About/FAQ did nothing, and cmd/ctrl-click never opened a new tab. Both now fall through to normal navigation.inertwhen closed; toggle hasaria-expanded/aria-controls.rel="noopener noreferrer".public/index.html(Firebase "Hosting Setup Complete" boilerplate at the same path as/).Typecheck, lint,
next buildpass; exportedout/index.htmlis the app page.Not fixed (needs an asset)
/og-image.jpgis referenced 3× inapp/layout.tsx(OG, Twitter, JSON-LD) but doesn't exist, so link previews have no image. Add a 1200×630 image topublic/.Note
Low Risk
Small UI, navigation, and accessibility fixes on the marketing site; no auth, data, or backend changes.
Overview
Fixes several Hacklytics 2027 landing-page UX and accessibility issues and removes stale Firebase hosting boilerplate.
The hero countdown now targets 5pm ET (
2027-02-26T17:00:00-05:00) so it matches JSON-LDstartDateinstead of interpreting a timezone-less string as each visitor’s local midnight.Navbar in-page anchor handling only runs for plain left-clicks when the section exists on the current page; modifier-key / new-tab clicks and links from the 404 page fall through to normal
/#…navigation. The mobile menu getsinertwhen closed (so hidden links leave tab order / the a11y tree), plusaria-expanded/aria-controlson the toggle andid="mobile-menu". The MLH trust badge addsrel="noopener noreferrer".Deletes
public/index.html, the default Firebase “Hosting Setup Complete” page that could compete with the Next export at/.Reviewed by Cursor Bugbot for commit 385a79a. Bugbot is set up for automated code reviews on this repo. Configure here.