Feature: rebase/eslint-react-compiler to dev - #415
Merged
Merged
Conversation
Move every workspace package to TypeScript 7.0.2, including sites/hacklytics2027 (was 5.8.3). No tsconfig or source changes were needed; tsc --noEmit and next build type checking both pass on 7. tooling/eslint stays on TypeScript 6.0.2 on purpose: TS 7 no longer ships the classic JS API, and typescript-eslint (latest 8.70.1) still requires typescript <6.1.0. Every lint config resolves typescript-eslint through @query/eslint-config, so pinning it there keeps lint working while the rest of the repo compiles with TS 7.
Brings every dependency with a same-major update to its latest release, including Next.js 16.3.6 (latest stable), tRPC 11.19, TanStack Query 5.103, drizzle, Tailwind 4.3, React 19.3, eslint 10.11 and typescript-eslint 8.70.1. No source changes needed.
- zod 3 -> 4. `.default({})` on the createPaymentIntent input now uses
`.prefault({})`, which keeps zod 3's behaviour of running the inner
field defaults. zod 4's `.uuid()` is RFC-strict; the database only
generates v4 ids (defaultRandom), so the stricter check stays and the
router test fixtures now use valid UUIDs instead of 0000...0001.
- nodemailer 9 -> 10: `SentMessageInfo.pending` is optional; guard it.
- vitest 4 -> 5: vite is now a peer dependency, so it is installed
explicitly at the root and in @query/api.
- @stripe/stripe-js 5 -> 9, @stripe/react-stripe-js 3 -> 6, dotenv 16 -> 18,
qrcode.react 3 -> 4, cross-env 7 -> 10: no code changes needed.
- Drop @types/minimatch and @types/qrcode.react (deprecated; both
packages ship their own types).
- @types/node stays on 22.x to match engines (node <24).
- vitest 5 requires Node ^22.12. test.yml ran on Node 20; move it to 22, matching pnpm-ci.yml. vitest is dev-only, so the App Hosting runtime (nodejs20) and the engines range are unaffected. - package.json asked for vite ^7.3.6 while the pnpm override pins ^7.3.5, so the lockfile recorded a different specifier than the manifest. Both now say ^7.3.5; pnpm install --frozen-lockfile passes.
Upgrade major dependencies and migrate (zod 4, vitest 5, nodemailer 10, Stripe)
Upgrades @eslint/js 10, @eslint/compat 2, eslint-config-prettier 10, eslint-plugin-react-hooks 7 and globals 17, and drops the deprecated @types/eslint__js. react-hooks 7's recommended set adds the React Compiler rules. Both sites build with reactCompiler: true, so these are real findings, not style. Fixes for the 31 new errors: - Mounted flags (`useEffect(() => setMounted(true), [])`) become `useIsClient()`, a useSyncExternalStore hook in lib/use-is-client.ts. - Resize listeners that mirror window.innerWidth into state become `useWindowWidth()` in lib/use-window-width.ts. Hero reads its prop directly instead of copying it into state. - Forms seeded from query data, and state reset when an input changes, use the "adjust state during render" pattern guarded by the previous value, so the stale value never paints. - AdminLayout derives `loading` instead of storing it; the Stripe modal memoizes loadStripe; EventFormModal seeds the date in its initial state; verify uses window.location.assign; the judging page updates its ref in an effect instead of during render. - LazySection drops the IntersectionObserver-missing fallback (every supported browser has it) and the hacklytics countdown seeds its first tick from the initial state. - AttendeesTab: drop a useless initial assignment (no-useless-assignment).
- Admin judging: move the selection ref and prep generation in the click handler instead of a post-render effect. Between render and that effect, a prep run for the previous edition still passed stillThisRun and could land its result on the newly selected edition's panel. Re-selecting the current edition is now a no-op so it cannot orphan its own run. - ResumePreview: remount per src via key instead of keying state by src. Going A -> B -> A before B loaded matched A's retained blob URL, which the A -> B cleanup had already revoked, and showed a broken PDF.
aamoghS
force-pushed
the
rebase/eslint-react-compiler
branch
from
September 24, 2026 19:45
6fc0532 to
8d05dc9
Compare
github-actions
Bot
added
the
dependencies
Contributor
Author
Dependency ReviewThe following issues were found:
|
Contributor
Author
|
Visit the preview URL for this PR (updated for commit 8d05dc9): https://hacklytics2027--pr-415-lps0671x.web.app (expires Thu, 01 Oct 2026 19:46:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c48ba34db61581e25fe2978355160b5eefe0e83f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated PR tracking changes from
rebase/eslint-react-compilerintodev.Note
Medium Risk
Wide dependency major bumps (especially Zod 4 and payment-related packages) plus many portal UI timing changes; admin judging and Stripe input tweaks touch operational flows but are mostly refactors with targeted race fixes.
Overview
This PR rebases eslint-react-compiler work into
devwith a broad toolchain bump (CI Node 22, TypeScript 7, Next/React 19.3, Vitest 5, Zod 4, tRPC/Stripe/tailwind/eslint refresh) across the monorepo.The main product change is React Compiler–friendly client patterns: new
useIsClientanduseWindowWidthhooks (useSyncExternalStore) replaceuseEffectmount/resize hacks across mainweb, hacklytics2027, and shared components. Many flows move state sync from effects into render (form prefills, filter resets, hackathon auto-select, judge queue seeding, admin judging prep) to avoid stale UI and race bugs—notablyselectHackathonbumps a generation counter before switching editions so in-flight prep cannot apply to the wrong hackathon.Smaller API/auth fixes: Stripe
createPaymentIntentinput uses Zod 4.prefault({}), nodemailer treatspendingas optional, and router tests use valid UUID v4 fixtures. Hacklytics countdown and lazy sections drop redundant effect/fallback logic; Stripe modal loadsloadStripeviauseMemo; resume preview remounts persrc.Reviewed by Cursor Bugbot for commit 8d05dc9. Bugbot is set up for automated code reviews on this repo. Configure here.