Add otel endpoint in weblog [php@MilanGarnier/propagation-behavior-extract] by MilanGarnier · Pull Request #7190 · DataDog/system-tests

MilanGarnier · 2026-06-22T11:27:17Z

Motivation

Add a PHP weblog endpoint that extracts distributed tracing context via the
OTel propagator API and forwards a request to a downstream URL. This is needed
to test DD_TRACE_PROPAGATION_BEHAVIOR_EXTRACT behavior (restart / ignore)
when context extraction goes through the OTel drop-in bridge.

Changes

New endpoint GET /otel_drop_in_extract_and_make_distant_call?url=<url>
(utils/build/docker/php/common/otel_drop_in_extract_and_make_distant_call.php):
- Extracts incoming trace context using OpenTelemetry\API\Globals::propagator()->extract(),
  which the DDTrace bridge maps to consume_distributed_tracing_headers.
- Creates an OTel server span parented to the extracted context.
- Makes an outbound cURL request to the provided url, propagating the
  active context through DDTrace's auto-instrumentation.
- Returns JSON with url, status_code, request_headers, and
  response_headers for assertion in tests.
Rewrite rule added in rewrite-rules.conf (with [QSA] to preserve
the url query parameter).
Enables Test_ExtractBehavior_Restart_Otel for PHP >= 8.1 versions

Workflow

⚠️ Create your PR as draft ⚠️
Work on you PR until the CI passes
Mark it as ready for review
- Test logic is modified? -> Get a review from RFC owner.
- Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed and the CI green, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

Anything but tests/ or manifests/ is modified ? I have the approval from R&P team
A docker base image is modified?
- the relevant build-XXX-image label is present
A scenario is added, removed or renamed?
- Get a review from R&P team

github-actions · 2026-06-22T11:29:39Z

CODEOWNERS have been resolved as:

utils/build/docker/php/common/otel_drop_in_extract_and_make_distant_call.php  @DataDog/apm-php @DataDog/system-tests-core
manifests/php.yml                                                       @DataDog/apm-php @DataDog/asm-php
utils/build/docker/php/common/rewrite-rules.conf                        @DataDog/apm-php @DataDog/system-tests-core

datadog-datadog-prod-us1 · 2026-06-22T11:35:17Z

Tests

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 9 Pipeline jobs failed

Testing the test | System Tests (php, dev) / End-to-end #10 / php-fpm-8.1 10

🧪 3 Tests failed

tests.test_library_conf.Test_ExtractBehavior_Restart_Otel.test_multiple_tracecontexts[php-fpm-8.1] from system_tests_suite

AssertionError: assert &#39;1&#39; != &#39;1&#39;
 &#43;  where &#39;1&#39; = &lt;bound method DataDogAgentSpanLegacy.get of &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7f35fc379160&gt;&gt;(&#39;traceID&#39;)
 &#43;    where &lt;bound method DataDogAgentSpanLegacy.get of &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7f35fc379160&gt;&gt; = &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7f35fc379160&gt;.get

self = &lt;tests.test_library_conf.Test_ExtractBehavior_Restart_Otel object at 0x7f3614b38e30&gt;

    def test_multiple_tracecontexts(self):
        interfaces.library.assert_trace_exists(self.r)
        spans = interfaces.agent.get_spans_list(self.r)
    
...

tests.test_library_conf.Test_ExtractBehavior_Restart_Otel.test_multiple_tracecontexts_with_overrides[php-fpm-8.1] from system_tests_suite

AssertionError: assert &#39;1&#39; != &#39;1&#39;
 &#43;  where &#39;1&#39; = &lt;bound method DataDogAgentSpanLegacy.get of &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7f35fc515490&gt;&gt;(&#39;traceID&#39;)
 &#43;    where &lt;bound method DataDogAgentSpanLegacy.get of &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7f35fc515490&gt;&gt; = &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7f35fc515490&gt;.get

self = &lt;tests.test_library_conf.Test_ExtractBehavior_Restart_Otel object at 0x7f3614b38e60&gt;

    def test_multiple_tracecontexts_with_overrides(self):
        interfaces.library.assert_trace_exists(self.r)
        spans = interfaces.agent.get_spans_list(self.r)
    
...

View all 3 test failures

Testing the test | System Tests (php, dev) / End-to-end #4 / apache-mod-8.2 4

🧪 3 Tests failed

tests.test_library_conf.Test_ExtractBehavior_Restart_Otel.test_multiple_tracecontexts[apache-mod-8.2] from system_tests_suite

AssertionError: assert &#39;1&#39; != &#39;1&#39;
 &#43;  where &#39;1&#39; = &lt;bound method DataDogAgentSpanLegacy.get of &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7fe784bd7d10&gt;&gt;(&#39;traceID&#39;)
 &#43;    where &lt;bound method DataDogAgentSpanLegacy.get of &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7fe784bd7d10&gt;&gt; = &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7fe784bd7d10&gt;.get

self = &lt;tests.test_library_conf.Test_ExtractBehavior_Restart_Otel object at 0x7fe7ac4670b0&gt;

    def test_multiple_tracecontexts(self):
        interfaces.library.assert_trace_exists(self.r)
        spans = interfaces.agent.get_spans_list(self.r)
    
...

tests.test_library_conf.Test_ExtractBehavior_Restart_Otel.test_multiple_tracecontexts_with_overrides[apache-mod-8.2] from system_tests_suite

AssertionError: assert &#39;1&#39; != &#39;1&#39;
 &#43;  where &#39;1&#39; = &lt;bound method DataDogAgentSpanLegacy.get of &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7fe784917290&gt;&gt;(&#39;traceID&#39;)
 &#43;    where &lt;bound method DataDogAgentSpanLegacy.get of &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7fe784917290&gt;&gt; = &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7fe784917290&gt;.get

self = &lt;tests.test_library_conf.Test_ExtractBehavior_Restart_Otel object at 0x7fe7ac467b90&gt;

    def test_multiple_tracecontexts_with_overrides(self):
        interfaces.library.assert_trace_exists(self.r)
        spans = interfaces.agent.get_spans_list(self.r)
    
...

View all 3 test failures

Testing the test | System Tests (php, dev) / End-to-end #5 / apache-mod-8.2-zts 5

🧪 3 Tests failed

tests.test_library_conf.Test_ExtractBehavior_Restart_Otel.test_multiple_tracecontexts[apache-mod-8.2-zts] from system_tests_suite

AssertionError: assert &#39;1&#39; != &#39;1&#39;
 &#43;  where &#39;1&#39; = &lt;bound method DataDogAgentSpanLegacy.get of &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7fd5f4e8a5a0&gt;&gt;(&#39;traceID&#39;)
 &#43;    where &lt;bound method DataDogAgentSpanLegacy.get of &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7fd5f4e8a5a0&gt;&gt; = &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7fd5f4e8a5a0&gt;.get

self = &lt;tests.test_library_conf.Test_ExtractBehavior_Restart_Otel object at 0x7fd609dd9220&gt;

    def test_multiple_tracecontexts(self):
        interfaces.library.assert_trace_exists(self.r)
        spans = interfaces.agent.get_spans_list(self.r)
    
...

tests.test_library_conf.Test_ExtractBehavior_Restart_Otel.test_multiple_tracecontexts_with_overrides[apache-mod-8.2-zts] from system_tests_suite

AssertionError: assert &#39;1&#39; != &#39;1&#39;
 &#43;  where &#39;1&#39; = &lt;bound method DataDogAgentSpanLegacy.get of &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7fd5f47d7890&gt;&gt;(&#39;traceID&#39;)
 &#43;    where &lt;bound method DataDogAgentSpanLegacy.get of &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7fd5f47d7890&gt;&gt; = &lt;utils.dd_types._datadog_agent_trace.DataDogAgentSpanLegacy object at 0x7fd5f47d7890&gt;.get

self = &lt;tests.test_library_conf.Test_ExtractBehavior_Restart_Otel object at 0x7fd609dd93a0&gt;

    def test_multiple_tracecontexts_with_overrides(self):
        interfaces.library.assert_trace_exists(self.r)
        spans = interfaces.agent.get_spans_list(self.r)
    
...

View all 3 test failures

View all 9 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: dc09660 | Docs | Datadog PR Page | Give us feedback!}

datadog-system-tests-org · 2026-06-22T11:35:39Z

⚠️ Warnings

🚦 31 Pipeline jobs failed

Testing the test | Fail if target branch is specified

Testing the test | System Tests (php, dev) / End-to-end #1 / apache-mod-7.0-zts 1

Testing the test | System Tests (php, dev) / End-to-end #1 / php-fpm-7.1 1

View all 31 failed jobs.

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: b8a4af3 | Docs | Give us feedback!}

…ker/php/common/otel_drop_in_extract_and_make_distant_call.php

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b8a4af3722

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Add otel endpoint in weblog

1cb514c

MilanGarnier changed the title ~~Add otel endpoint in weblog~~ Add otel endpoint in weblog [php@MilanGarnier/propagation-behavior-extract] Jun 22, 2026

MilanGarnier added 2 commits June 22, 2026 14:14

Enable Test_ExtractBehavior_Restart_Otel from 1.22

8cba018

lowercase headers before returning them in php weblog utils/build/doc…

b8a4af3

…ker/php/common/otel_drop_in_extract_and_make_distant_call.php

MilanGarnier marked this pull request as ready for review June 23, 2026 12:13

MilanGarnier requested review from a team as code owners June 23, 2026 12:13

MilanGarnier marked this pull request as draft June 23, 2026 12:14

chatgpt-codex-connector Bot reviewed Jun 23, 2026

View reviewed changes

Comment thread manifests/php.yml Outdated

MilanGarnier added 3 commits June 23, 2026 14:34

Fix: Only enable versions who have the drop-in endpoint

016a21e

no manual span start->end (handled by autoinstrumentation)

81cc81d

Update otel_drop_in_extract_and_make_distant_call.php

dc09660

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add otel endpoint in weblog [php@MilanGarnier/propagation-behavior-extract]#7190

Add otel endpoint in weblog [php@MilanGarnier/propagation-behavior-extract]#7190
MilanGarnier wants to merge 6 commits into
mainfrom
milan.garnier/php-weblog

MilanGarnier commented Jun 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 22, 2026 •

edited

Loading

Uh oh!

datadog-datadog-prod-us1 Bot commented Jun 22, 2026 •

edited by datadog-official Bot

Loading

Uh oh!

datadog-system-tests-org Bot commented Jun 22, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

MilanGarnier commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

Workflow

Reviewer checklist

Uh oh!

github-actions Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datadog-datadog-prod-us1 Bot commented Jun 22, 2026 • edited by datadog-official Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

datadog-system-tests-org Bot commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

MilanGarnier commented Jun 22, 2026 •

edited

Loading

github-actions Bot commented Jun 22, 2026 •

edited

Loading

datadog-datadog-prod-us1 Bot commented Jun 22, 2026 •

edited by datadog-official Bot

Loading

datadog-system-tests-org Bot commented Jun 22, 2026 •

edited

Loading