feat(config): add dynamic typed-config router for prefix filter#1919
Draft
webern wants to merge 4 commits into
Draft
feat(config): add dynamic typed-config router for prefix filter#1919webern wants to merge 4 commits into
webern wants to merge 4 commits into
Conversation
webern
changed the title
dd-octo-sts
Bot
added
the
area/test
This was referenced Jun 24, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
|
Add the source-agnostic PrefixFilterConfig leaf type in saluki-component-config and embed it in the DogStatsD domain group. Fill the six Datadog witness methods that were no-ops and add translation tests.
Introduce ArcSwap<SalukiConfiguration> in ConfigurationSystem so the dynamic router can atomically swap retranslated configs. Add DynamicConfigHandles with a ScopedConfig<PrefixFilterConfig> handle that wakes on accepted runtime updates.
Rename DogStatsDPrefixFilterConfiguration to DogStatsDPrefixFilterBuilder. Replace the GenericConfiguration raw-key watchers with a single ScopedConfig<PrefixFilterConfig> handle. Wire through add_dsd_pipeline_to_blueprint using system.dynamic_handles().prefix_filter.
Panoramic test that exercises the full dynamic typed-config pipeline: Core Agent config set -> GenericConfiguration -> router retranslation -> /config/internal serves the updated prefix_filter slice.
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (35)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human Summary
This migrates a second configuration struct,
DogStatsDPrefixFilterConfigurationto the typed configuration system. This one is dynamic and serves as a forcing function to get typed dynamic config updates working.AI Summary
Adds
PrefixFilterConfigas a source-agnostic native struct insaluki-component-configandimplements a dynamic config router in
agent-data-plane-config-systemthat subscribes to raw-mapupdate events, re-translates the full Datadog config, atomically swaps the current
SalukiConfigurationviaArcSwap, and publishes changed slices throughDynamicConfig<T>watchhandles.
Migrates the DogStatsD prefix filter component from raw-key
watch_for_updates()watchers +GenericConfigurationto a singleDynamicConfig<PrefixFilterConfig>handle. The 4-armselect!loop (one per watched key) becomes a single
changed()arm that rebuilds theEffectiveFilterlistfrom a typed snapshot.
Fills the 6 no-op witness
consume_*methods for the prefix filter keys so translation populatesPrefixFilterConfigfields.Change Type
How did you test this PR?
recovery, fixed mode, ArcSwap visibility)
_blacklistalias)DynamicConfig::fixed()andDynamicConfig::live()metric_filterlistvia control plane, verify on/config/internalmake check-all(clippy, Vale, unused-deps)References