chore(ci): build internal image without suffix using Nydus

[FlorentClarret]

Summary

DataDog/datadog-agent#52712 's counterpart for ADP. It starts using the new version added here. Nydus is supported on all clusters internally and is currently already deployed everywhere.

I discussed with Toby and we don't need to keep the previous image (with the suffix) since we only deploy this image for custom builds.

Change Type

• Bug fix
• New feature
• Non-functional (chore, refactoring, docs)
• Performance

How did you test this PR?

Ran in the CI

References

Part of https://datadoghq.atlassian.net/browse/BARX-1184

[tobz]

I am... not sure why CI did not trigger here. Might be worth doing an empty commit just to try and give it a kickstart.

[FlorentClarret]

I am... not sure why CI did not trigger here. Might be worth doing an empty commit just to try and give it a kickstart.

@tobz GitLab says

This GitLab CI configuration is invalid: display-image-tags job: undefined need: publish-adp-image-internal.

which... does not make sense to me. I'll investigate

Edit: TLDR: it seems like you can't needs something inside the rules section if the job you needs is a parralel:matrix one

[pr-commenter]

Binary Size Analysis (Agent Data Plane)

Baseline: 9c1abde · Comparison: d8714db · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 40.37 MiB (baseline) vs 40.37 MiB (comparison)
Size Change: -8 B (-0.00%)

✅ Binary size difference within threshold

Changes by Module

Module	File Size	Symbols
anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.12576821623472313372	-130 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.7867933985014613824	+129 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.12576821623472313372	-115 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.7867933985014613824	+114 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.12576821623472313372	-109 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.7867933985014613824	+108 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.12576821623472313372	-97 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.7867933985014613824	+96 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.12576821623472313372	-95 B	1
anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.7867933985014613824	+94 B	1
[Unmapped]	-3 B	1

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW]    +129  [NEW]     +40    anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.7867933985014613824
  [NEW]    +114  [NEW]     +25    anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.7867933985014613824
  [NEW]    +108  [NEW]     +19    anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.7867933985014613824
  [NEW]     +96  [NEW]      +7    anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.7867933985014613824
  [NEW]     +94  [NEW]      +5    anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.7867933985014613824
  -0.0%      -3  [ = ]       0    [Unmapped]
  [DEL]     -95  [DEL]      -5    anon.c332a4a573d0a9a1bf7c71b0a1f57672.2.llvm.12576821623472313372
  [DEL]     -97  [DEL]      -7    anon.c332a4a573d0a9a1bf7c71b0a1f57672.0.llvm.12576821623472313372
  [DEL]    -109  [DEL]     -19    anon.c332a4a573d0a9a1bf7c71b0a1f57672.3.llvm.12576821623472313372
  [DEL]    -115  [DEL]     -25    anon.c332a4a573d0a9a1bf7c71b0a1f57672.4.llvm.12576821623472313372
  [DEL]    -130  [DEL]     -40    anon.c332a4a573d0a9a1bf7c71b0a1f57672.1.llvm.12576821623472313372
  -0.0%      -8  [ = ]       0    TOTAL

[pr-commenter]

Regression Detector (Agent Data Plane)

Run ID: 19b454f7-22f7-47cd-8998-cbeb40a91d57
Baseline: 9c1abdeb · Comparison: 050c339b · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (35)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment	goal	Δ mean %	links
otlp_ingest_metrics_5mb_cpu (erratic)	cpu	⚪ +2.95	metrics profiles logs
otlp_ingest_metrics_5mb_memory	memory	⚪ +1.86	metrics profiles logs
otlp_ingest_traces_ottl_transform_5mb_cpu (erratic)	cpu	⚪ +1.48	metrics profiles logs
otlp_ingest_logs_5mb_cpu (ignored)	cpu	⚪ +1.02	metrics profiles logs
otlp_ingest_traces_ottl_transform_5mb_throughput	throughput	⚪ -0.59	metrics profiles logs
dsd_uds_512kb_3k_contexts_cpu (erratic)	cpu	⚪ +0.35	metrics profiles logs
dsd_uds_500mb_3k_contexts_memory	memory	⚪ +0.17	metrics profiles logs
quality_gates_rss_idle	memory	⚪ +0.11	metrics profiles logs
quality_gates_rss_dsd_heavy	memory	⚪ +0.09	metrics profiles logs
otlp_ingest_metrics_5mb_throughput	throughput	⚪ -0.04	metrics profiles logs
otlp_ingest_logs_5mb_throughput (ignored)	throughput	⚪ -0.03	metrics profiles logs
dsd_uds_100mb_3k_contexts_throughput	throughput	⚪ -0.03	metrics profiles logs
dsd_uds_100mb_3k_contexts_memory	memory	⚪ +0.02	metrics profiles logs
otlp_ingest_traces_ottl_filtering_5mb_memory	memory	⚪ +0.01	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory	⚪ +0.00	metrics profiles logs
otlp_ingest_traces_5mb_memory	memory	⚪ +0.00	metrics profiles logs
dsd_uds_10mb_3k_contexts_throughput	throughput	⚪ -0.00	metrics profiles logs
dsd_uds_1mb_3k_contexts_throughput	throughput	⚪ +0.00	metrics profiles logs
dsd_uds_512kb_3k_contexts_throughput	throughput	⚪ +0.00	metrics profiles logs
dsd_uds_1mb_3k_contexts_memory	memory	⚪ -0.05	metrics profiles logs
otlp_ingest_traces_ottl_transform_5mb_memory	memory	⚪ -0.07	metrics profiles logs
dsd_uds_512kb_3k_contexts_memory	memory	⚪ -0.09	metrics profiles logs
otlp_ingest_traces_5mb_throughput	throughput	⚪ +0.09	metrics profiles logs
dsd_uds_10mb_3k_contexts_memory	memory	⚪ -0.20	metrics profiles logs
quality_gates_rss_dsd_low	memory	⚪ -0.25	metrics profiles logs
quality_gates_rss_dsd_medium	memory	⚪ -0.45	metrics profiles logs
otlp_ingest_traces_ottl_filtering_5mb_throughput	throughput	⚪ +0.48	metrics profiles logs
dsd_uds_500mb_3k_contexts_cpu (erratic)	cpu	⚪ -0.61	metrics profiles logs
otlp_ingest_traces_ottl_filtering_5mb_cpu (erratic)	cpu	⚪ -1.05	metrics profiles logs
otlp_ingest_traces_5mb_cpu (erratic)	cpu	⚪ -1.30	metrics profiles logs
otlp_ingest_logs_5mb_memory (ignored)	memory	⚪ -1.68	metrics profiles logs
dsd_uds_500mb_3k_contexts_throughput	throughput	⚪ +2.45	metrics profiles logs
dsd_uds_1mb_3k_contexts_cpu (erratic)	cpu	⚪ -2.74	metrics profiles logs
dsd_uds_100mb_3k_contexts_cpu (erratic)	cpu	⚪ -3.33	metrics profiles logs
dsd_uds_10mb_3k_contexts_cpu (erratic)	cpu	🟢 -6.93	metrics profiles logs

Bounds Checks: ✅ Passed (5)

experiment	check	replicates	observed	links
quality_gates_rss_dsd_heavy	memory_usage	10/10	✅ 139 MiB ≤ 140 MiB	metrics profiles logs
quality_gates_rss_dsd_low	memory_usage	10/10	✅ 42.5 MiB ≤ 50 MiB	metrics profiles logs
quality_gates_rss_dsd_medium	memory_usage	10/10	✅ 64.9 MiB ≤ 75 MiB	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory_usage	10/10	✅ 191 MiB ≤ 200 MiB	metrics profiles logs
quality_gates_rss_idle	memory_usage	10/10	✅ 28.2 MiB ≤ 40 MiB	metrics profiles logs

Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 050c339b5a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".