[Cisco ACI] Add logging for clarity on failures/no metrics to emit#24177
[Cisco ACI] Add logging for clarity on failures/no metrics to emit#24177zoedt wants to merge 2 commits into
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5bfb6c7f7d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| except (exceptions.APIConnectionException, exceptions.APIParsingException): | ||
| pass | ||
| except (exceptions.APIConnectionException, exceptions.APIParsingException) as e: | ||
| self.log.warning("Failed to collect stats for pod %s: %s", pod_id, e) |
There was a problem hiding this comment.
Add the required changelog entry
This changes shipped Agent code under datadog_checks/, but the commit only includes fabric.py. /workspace/integrations-core/AGENTS.md says, “Changelog entries are required for any change to a file that is shipped with the Agent,” including Python sources under datadog_checks/, so this needs the matching cisco_aci/changelog.d/<PR_NUMBER>.<TYPE> entry once the PR number is available.
Useful? React with 👍 / 👎.
b3798a5 to
dd703f3
Compare
Validation ReportAll 21 validations passed. Show details
|
What does this PR do?
Motivation
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged