OCSF pipeline for cato-networks#24155
Open
jbfeldman-dd wants to merge 6 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed22ea6021
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Add missing core OCSF facets (activity, category, class, severity, status, type, confidence, action, direction, rcode, state, auth_protocol) - Remove forbidden facetType/type keys from port and time facets - Fix OCSF facet indentation to 6-space to match non-OCSF facets - Add action_id mapper to Network Activity [4001] sub-pipeline - Restructure 2004 activity_id to ascending order with Other(99) fallback - Rename pre-transformation string-builders per naming conventions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add type: integer to ID facets (activity_id, category_uid, class_uid, severity_id, status_id, type_uid, action_id, auth_protocol_id, rcode_id) - Restore facetType: range and type: integer on port and time facets - Fix facet names to match shared definitions (Category, Class, Type ID, Response Code, etc.) - Drop direction/direction_id facets (already owned by shared facet list) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Validation ReportAll 21 validations passed. Show details
|
gfoss
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?