Repository navigation
fix(flags): report the loaded JavaScript package version - #1463
Draft
leoromanovsky wants to merge 2 commits into
Draft
leoromanovsky wants to merge 2 commits into
leoromanovsky wants to merge 2 commits into
Conversation
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 4 Pipeline jobs failed
ℹ️ InfoNo other issues found (see more)🧪 All tests passed Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 61116e9 | Docs | View more details | Give us feedback! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Precompute requests can report a native SDK or compiled bridge version instead of the loaded React Native JavaScript version.
Changes and Decisions
Pass the existing generated JavaScript version through the Flags bridge. Report it as
source.sdk_versionwithsdk_name: dd-sdk-reactnative. Keep RUM metadata unchanged.Requires releases of iOS #3262 and Android #3946, followed by updated native dependency pins.