Repository navigation
Conversation
This was referenced Jul 24, 2026
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR2
branch
from
July 27, 2026 20:13
cb5597d to
932c87b
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR3
branch
from
July 27, 2026 20:28
dbf9a5f to
ec8e68a
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR2
branch
from
July 28, 2026 19:47
932c87b to
a725eb5
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR3
branch
2 times, most recently
from
July 29, 2026 14:27
d6670ab to
b4dc7a4
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR2
branch
2 times, most recently
from
July 30, 2026 13:37
45a8242 to
0cc9e56
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR3
branch
from
July 30, 2026 13:37
b4dc7a4 to
f668b3f
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR2
branch
from
July 31, 2026 13:58
0cc9e56 to
31018a5
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR3
branch
from
July 31, 2026 13:58
f668b3f to
b612833
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR2
branch
from
August 3, 2026 15:45
31018a5 to
c804067
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR3
branch
from
August 3, 2026 15:45
b612833 to
87ae73c
Compare
1 task
sameerank
reviewed
Aug 6, 2026
Comment on lines
+75
to
+77
| isEmptyContext(_context) | ||
| ? undefined | ||
| : toDdContextPreservingTargetingKey(_context), |
There was a problem hiding this comment.
This converts an empty effective OpenFeature context ({}) to undefined, causing FlagsClient to reuse its stored/embedded context, and this is being removed in #1359, right?
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR2
branch
from
August 7, 2026 01:00
c804067 to
0014b99
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR3
branch
from
August 7, 2026 01:00
87ae73c to
6e3fcfe
Compare
11 tasks done
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR2
branch
from
August 7, 2026 12:24
0014b99 to
8a11853
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR3
branch
from
August 7, 2026 12:24
6e3fcfe to
2bdc125
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR2
branch
from
August 10, 2026 18:54
8a11853 to
d4d92d0
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR3
branch
from
August 10, 2026 18:54
2bdc125 to
c261929
Compare
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 0209c29 | Docs | View more details | Give us feedback! |
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR2
branch
from
August 11, 2026 20:09
d4d92d0 to
7b38d92
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR3
branch
from
August 11, 2026 20:09
c261929 to
c7fee24
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR2
branch
from
August 18, 2026 12:39
7b38d92 to
7e4aca2
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR3
branch
from
August 18, 2026 12:39
c7fee24 to
423ae55
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR2
branch
from
August 20, 2026 16:37
7e4aca2 to
a678a7e
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR3
branch
from
August 20, 2026 16:37
423ae55 to
ac5785f
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR2
branch
from
September 15, 2026 13:56
a678a7e to
1f6c1d3
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR3
branch
2 times, most recently
from
September 15, 2026 15:26
7670c4a to
391e617
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR2
branch
from
September 18, 2026 13:50
7ea2311 to
0a88b52
Compare
btthomas
force-pushed
the
blake.thomas/FFL-2837-PR3
branch
from
September 18, 2026 13:50
391e617 to
0209c29
Compare
4 tasks done
Contributor
|
Closing since we took a different implementation path |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request stack
This description uses Simplified Technical English. Technical names and API names do not change.
Summary
This PR exposes dynamic offline rules through the existing offline provider.
FlagsClient.{}as a real context.clearContext()does not restore a context from the configuration.ReadybeforeConfigurationChanged.Protobuf integration
rules.responseenvelope.int64PARSE_ERRORand no tracking for that error.rulesBasedJSON fixture remains.OpenFeature behavior
OpenFeature supplies
{}for an unset or cleared global context. The provider cannot distinguish this state from an explicit{}. Therefore, it passes{}literally. For a context-specific precomputed configuration, the application explicitly sets the context returned bygetPrecomputedContext(configuration).Matching precomputed data has priority when both capabilities exist. Rules data is the fallback for a different context.
TODO status
This PR adds no new
TODO(FFL-2837)marker. The complete stacked branch has the two PR1 follow-ups for regular-expression limits and the future peer-dependency minimum.Checks
git diff --checkThis PR remains a draft.