feat(flags): evaluate dynamic offline rules (FFL-2837 PR2)

packages/core/src/flags/configuration/__tests__/__utils__/rulesTestUtils.ts

@@ -14,9 +14,9 @@ import type {
 import { configurationFromString } from '../../wire';
 
 // A complete protobuf response from the flagging-core 3.0.0 wire contract.
-// It contains one static boolean flag with the key `browser-flag`.
+// It contains one static boolean flag with the key `dynamic-flag`.
 export const RULES_RESPONSE =
-    'EgRwcm9kGigKDGJyb3dzZXItZmxhZxIYEAQaAigBIhAKCmFsbG9jYXRpb24iAiADKgJvbg==';
+    'EgRwcm9kGigKDGR5bmFtaWMtZmxhZxIYEAQaAigBIhAKCmFsbG9jYXRpb24iAiADKgJvbg==';
 
 export const buildRulesWire = (response: string = RULES_RESPONSE): string =>
     JSON.stringify({

packages/core/src/flags/configuration/__tests__/rules.test.ts

@@ -72,7 +72,7 @@ describe('rules configuration', () => {
         const result = flaggingCoreRulesEngine.evaluate({
             configuration: buildRulesConfiguration(),
             type: 'boolean',
-            flagKey: 'browser-flag',
+            flagKey: 'dynamic-flag',
             defaultValue: false,
             context: { targetingKey: 'user-1' },
             logger: getNoopRulesLogger()
@@ -92,13 +92,13 @@ describe('rules configuration', () => {
 
     it('preserves a deterministic flag-scoped PARSE_ERROR', () => {
         const configuration = buildRulesConfiguration();
-        configuration.flags['browser-flag'].minimumFeatureLevel = 1;
+        configuration.flags['dynamic-flag'].minimumFeatureLevel = 1;
 
         expect(
             flaggingCoreRulesEngine.evaluate({
                 configuration,
                 type: 'boolean',
-                flagKey: 'browser-flag',
+                flagKey: 'dynamic-flag',
                 defaultValue: false,
                 context: { targetingKey: 'user-1' },
                 logger: getNoopRulesLogger()
@@ -144,7 +144,7 @@ describe('rules configuration', () => {
             fake.evaluate({
                 configuration: buildRulesConfiguration(),
                 type: 'boolean',
-                flagKey: 'browser-flag',
+                flagKey: 'dynamic-flag',
                 defaultValue: false,
                 context: { targetingKey: 'user-1' },
                 logger: getNoopRulesLogger()

packages/core/src/flags/configuration/__tests__/wire.test.ts

@@ -10,7 +10,7 @@ import { configurationFromString, configurationToString } from '../wire';
 import { buildRulesWire, RULES_RESPONSE } from './__utils__/rulesTestUtils';
 
 const RULES_RESPONSE_WITH_UNKNOWN_FIELD =
-    'EgRwcm9kGigKDGJyb3dzZXItZmxhZxIYEAQaAigBIhAKCmFsbG9jYXRpb24iAiADKgJvbqAGBw==';
+    'EgRwcm9kGigKDGR5bmFtaWMtZmxhZxIYEAQaAigBIhAKCmFsbG9jYXRpb24iAiADKgJvbqAGBw==';
 
 const buildResponse = () => ({
     data: {
@@ -174,6 +174,6 @@ describe('configurationToString', () => {
         );
 
         expect(parsed.precomputed).toBeDefined();
-        expect(parsed.rules?.response.flags['browser-flag']).toBeDefined();
+        expect(parsed.rules?.response.flags['dynamic-flag']).toBeDefined();
     });
 });

packages/core/src/flags/configuration/precomputed.ts

@@ -154,7 +154,7 @@ const toFlagCacheEntry = (
         allocationKey,
         variationKey,
         variationType,
-        variationValue: stringifyValue(variationValue),
+        variationValue: stringifyFlagValue(variationValue),
         reason,
         doLog,
         // The native bridge still requires this deprecated field. Portable
@@ -199,7 +199,7 @@ const valueMatchesVariationType = (
  * Objects/arrays are JSON-encoded; everything else uses `String(...)`, which yields
  * lowercase `"true"/"false"` for booleans.
  */
-const stringifyValue = (value: unknown): string => {
+export const stringifyFlagValue = (value: unknown): string => {
     if (value === null) {
         return 'null';
     }

packages/core/src/flags/internal.ts

@@ -9,7 +9,7 @@ import { SdkVerbosity } from '../config/types/SdkVerbosity';
 
 import type { EvaluationContext, PrimitiveValue } from './types';
 
-export interface FlagCacheEntry {
+export interface TrackableAssignment {
     key: string;
     value: unknown;
     allocationKey: string;
@@ -21,6 +21,8 @@ export interface FlagCacheEntry {
     extraLogging: Record<string, unknown>;
 }
 
+export type FlagCacheEntry = TrackableAssignment;
+
 export const processEvaluationContext = (
     context: EvaluationContext
 ): EvaluationContext => {

packages/core/src/flags/types.ts

@@ -168,6 +168,7 @@ export interface EvaluationContext {
 type FlagErrorCode =
     | 'PROVIDER_NOT_READY'
     | 'FLAG_NOT_FOUND'
+    | 'TARGETING_KEY_MISSING'
     | 'PARSE_ERROR'
     | 'TYPE_MISMATCH'
     | 'INVALID_CONTEXT'

packages/react-native-openfeature/src/__tests__/offlineProvider.test.ts

@@ -8,6 +8,7 @@ import {
     ErrorCode,
     GeneralError,
     InvalidContextError,
+    ParseError,
     ProviderEvents,
     ProviderNotReadyError
 } from '@openfeature/web-sdk';
@@ -17,6 +18,7 @@ import { DatadogOfflineOpenFeatureProvider } from '../offlineProvider';
 const READY = { status: 'ready' as const };
 const mismatch = { status: 'error' as const, errorCode: 'INVALID_CONTEXT' };
 const notReady = { status: 'error' as const, errorCode: 'PROVIDER_NOT_READY' };
+const parseError = { status: 'error' as const, errorCode: 'PARSE_ERROR' };
 const generalError = { status: 'error' as const, errorCode: 'GENERAL' };
 
 const mockFlagsClient = {
@@ -106,6 +108,15 @@ describe('DatadogOfflineOpenFeatureProvider', () => {
         );
     });
 
+    it('rejects initialize with a parse error for an unusable configuration', async () => {
+        const provider = new DatadogOfflineOpenFeatureProvider();
+        mockFlagsClient.setEvaluationContextWithoutFetching.mockReturnValueOnce(
+            parseError
+        );
+
+        await expect(provider.initialize({})).rejects.toThrow(ParseError);
+    });
+
     it('reconciles a matching context change without fetching or signalling a change', () => {
         const provider = new DatadogOfflineOpenFeatureProvider();
         const emitSpy = jest.spyOn(provider.events, 'emit');

packages/react-native-openfeature/src/offlineProvider.ts

@@ -12,6 +12,7 @@ import {
     ErrorCode,
     GeneralError,
     InvalidContextError,
+    ParseError,
     ProviderEvents,
     ProviderNotReadyError
 } from '@openfeature/web-sdk';
@@ -40,6 +41,7 @@ type ProviderErrorEvent = { message: string; errorCode: ErrorCode };
 const OF_ERROR_CODE: Record<ConfigurationErrorCode, ErrorCode> = {
     INVALID_CONTEXT: ErrorCode.INVALID_CONTEXT,
     PROVIDER_NOT_READY: ErrorCode.PROVIDER_NOT_READY,
+    PARSE_ERROR: ErrorCode.PARSE_ERROR,
     GENERAL: ErrorCode.GENERAL
 };
 
@@ -177,6 +179,10 @@ export class DatadogOfflineOpenFeatureProvider extends DatadogCoreOpenFeaturePro
                 return new ProviderNotReadyError(
                     'The Datadog offline provider has no configuration loaded. Provide one via setConfiguration.'
                 );
+            case 'PARSE_ERROR':
+                return new ParseError(
+                    'The Datadog offline provider cannot parse the loaded configuration.'
+                );
             default:
                 return new GeneralError(
                     'The Datadog offline provider cannot serve the loaded configuration.'