Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make native module resolution lazy and expose core internals entry point #1316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Make native module resolution lazy and expose core internals entry point #1316
Changes from all commits
510c4d647b11161c84ce5File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On platforms where a TurboModule lookup is unsupported or throws, imports remain unsafe because
DdRumis created throughgetGlobalInstanceduring module evaluation and this field immediately callsgetNativeDdRum(). The new./internalentry reaches this wrapper throughDdRumResourceTracking -> ResourceReporter -> DdRum, while the public barrel imports it directly;DdLogs,DdTrace, andDdFlagshave the same eager field initialization. Resolve the module only when a wrapper operation actually needs it, otherwise both advertised import-safe entry points still perform native lookups.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When React Native Codegen processes the configured
src/specsdirectory for a new-architecture build, it expects each TurboModule spec to expose its registry call as the module's default export; moving the only call into this named getter leaves theSpecundiscoverable. The same change was made in all fiveNativeDd*files, so Codegen can no longer generate theNativeDdSdkSpec,NativeDdRumSpec, and related native base classes consumed by the checked-in Android/iOS implementations.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.