Repository navigation
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ All CI checks and tests passed. Datadog automation helped this PR pass. 🎉 All green!🧪 All tests passed 🔄 Datadog retried 1 test - 1 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: 261a2ee | Docs | View more details | Give us feedback! |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
…ofiling The quota check used to run for every RUM session. It now runs only for tracked sessions sampled for continuous profiling or owning the app launch profile. ANR trigger profiles request their own check when they are matched and are written once the decision for their session lands. Quota results carry their session id and are discarded once the session has changed, and the launch profile is judged by its own session only. The RUM session state is exposed through FeatureContextKeys.RUM_SESSION_STATE. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
269f395 to
261a2ee
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 261a2ee8a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| } | ||
|
|
||
| private fun tryWritePendingLaunchProfile() { |
There was a problem hiding this comment.
nit: replace method body with = to make it more clean
5 participants
What does this PR do?
The quota check used to run for every RUM session. It now runs only for tracked sessions sampled for continuous profiling or owning the app launch profile. ANR trigger profiles request their own check when they are matched and are written once the decision for their session lands.
Quota results carry their session id and are discarded once the session has changed, and the launch profile is judged by its own session only. The RUM session state is exposed through
FeatureContextKeys.RUM_SESSION_STATE.Similar change in iOS SDK DataDog/dd-sdk-ios#3256.
Review checklist (to be filled by reviewers)