Skip to content

Fix annotation for ProfilingConfiguration.applyRemoteConfiguration - #3959

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/fix-annotation-for-profiling-configuration-remote-config
Oct 6, 2026
Merged

0xnm merged 1 commit into
developfrom
nogorodnikov/fix-annotation-for-profiling-configuration-remote-config

Conversation

@0xnm

@0xnm 0xnm commented Oct 5, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Fix wrong usage of ExperimentalProfilingApi: in case of ProfilingConfiguration.applyRemoteConfiguration it should be the argument of OptIn instead.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners October 5, 2026 14:39
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T14:43:16.082460Z 41ae4e1 PR opened
🔒 Security Review ✅ Completed 2026-10-05T14:45:40.761903Z 41ae4e1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Tests

✅ All CI checks and tests passed. Datadog automation helped this PR pass.

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🔄 Datadog retried 1 test - 1 passed on retry View in Datadog

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 71.76% (-0.02%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 41ae4e1 | Docs | View more details | Give us feedback!

@maciejburda
maciejburda requested a review from ambushwork October 6, 2026 07:05
@0xnm 0xnm added the ready-for-human-review All agentic review feedback was addressed and PR is ready for the human review. label Oct 6, 2026
@0xnm
0xnm merged commit ecebe14 into develop Oct 6, 2026
26 checks passed
@0xnm
0xnm deleted the nogorodnikov/fix-annotation-for-profiling-configuration-remote-config branch October 6, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human-review All agentic review feedback was addressed and PR is ready for the human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants