Repository navigation
Add connect nodes to the activity tree - #523
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoSep 23, 2026
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
Conversation
1 task done
spikat
reviewed
Sep 23, 2026
Comment on lines
+314
to
+321
| message ConnectNode { | ||
| repeated MatchedRule matched_rules = 3; | ||
| NodeBase node_base = 4; | ||
|
|
||
| uint32 port = 1; | ||
| string ip = 2; | ||
| uint32 protocol = 5; | ||
| } |
Contributor
There was a problem hiding this comment.
as this one is the same as the BindNode, what about like deprecating the bind node and use the same object for both?
spikat
approved these changes
Sep 23, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
momar/add-connect-to-activity-tree
branch
September 23, 2026 15:16
gh-worker-dd-mergequeue-cf854d Bot
pushed a commit
to DataDog/datadog-agent
that referenced
this pull request
Sep 28, 2026
## What does this PR do? Adds support for inserting `connect` events into the V2 security profile activity trees, which was previously missing. This enables tracking outbound connection activity alongside existing bind, DNS, and other event types. ### Changes - Added `ConnectNode` struct (analogous to `BindNode`) to `SocketNode` with full lifecycle support: insertion, eviction, tagging, sizing, and graph rendering - Added `InsertConnectEvent` to `ProcessNode` with IPv4/IPv6 address family validation - Added protobuf encoding/decoding for `ConnectNode` using the new proto message from agent-payload - Added `"connect"` to the default V2 security profile event types - Added `connect_only` test case in `size_test.go` ### TODO - [x] Merge and release the corresponding [agent-payload PR](DataDog/agent-payload#523) first, then update `go.mod` to point to the released version before merging this PR Co-authored-by: momar.toure <momar.toure@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
ConnectNodeprotobuf message to the CWS activity dump schema (activity_dump.proto), with fields for port, IP, protocol, matched rules, and node base. The new message is added as arepeated ConnectNode connectfield onSocketNode, enabling serialization of outbound connection events in security profile activity trees.