[CWS] Add declared hardening infos by mftoure · Pull Request #519 · DataDog/agent-payload

mftoure · 2026-09-08T13:35:17Z

What does this PR do?

Add declared Kubernetes security context to CWS activity dumps and security profiles

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

Reviewers: please see the review guidelines.

lebauce · 2026-09-10T12:24:20Z

+    optional string localhost_profile = 2;
+}
+
+message HardeningDeclared {


Sorry for the bikeshedding but should this be something like SecurityContext ?

…erName) Co-authored-by: Cursor <cursoragent@cursor.com>

lebauce · 2026-09-14T11:51:04Z

+    }
+
+    Type type = 1;
+    // Set iff type == TYPE_LOCALHOST.


nit: s/iff/if/

spikat · 2026-09-14T13:55:59Z

+    optional bool run_as_non_root             = 5;
+    optional bool allow_privilege_escalation  = 6;
+    optional bool read_only_root_filesystem   = 7;


I don't think we should add those, as the raw information is already present on the profile itself, and we kind of agree with the backend to only share raw data

ok I wasn't aware we could directly got those intel from workload meta, and I don't have a strong opinion about adding them or not 🤔

Add a new SeccompFilter proto message carrying the effective seccomp filter extracted at runtime via ptrace: - default_action: the fallback action for unmatched syscalls - syscalls: map of syscall name to its action (ALLOW, ERRNO, etc.) The filter is an optional field on SeccompProfile (field 3). Co-authored-by: Cursor <cursoragent@cursor.com>

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 949802a991

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-09-17T12:30:09Z

+    // Set if type == TYPE_LOCALHOST.
+    optional string localhost_profile = 2;
+    // Effective filter extracted at runtime via ptrace.
+    optional SeccompFilter filter = 3;


Regenerate the Java bindings for the filter field

The checked-in SecDumpProto.java was generated before this field and message were added: it contains neither SeccompFilter nor SeccompProfile.hasFilter()/getFilter(), and its embedded descriptor still defines SeccompProfile with only fields 1 and 2. Consequently Java consumers treat field 3 as unknown and cannot inspect it, while Java producers cannot populate the new effective filter; regenerate the Java output from the final proto.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ca032512da

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-09-17T14:04:38Z

+    // Comparison operator: "==", "!=", "&", ">", ">=", "<", "<=".
+    string op = 2;
+    // Constant value compared against.
+    uint32 value = 3;


Use a 64-bit value for seccomp argument conditions

For filters comparing an argument with a constant above 0xffffffff, such as a 64-bit mask or pointer-valued argument, this field cannot encode the effective condition. Linux exposes every seccomp syscall argument as a 64-bit value, and this model has no separate high-word marker, so a producer must truncate or reject such a comparison and the receiver reconstructs a different filter. Use uint64 for the comparison value.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-09-17T14:04:38Z

+}
+
+message SecurityContext {
+    bool privileged = 1;


Preserve presence of the privileged declaration

When a workload omits securityContext.privileged, this proto3 scalar decodes identically to an explicit privileged: false. Because these entries describe declared security settings, consumers cannot tell whether the workload explicitly disabled privileged mode or merely inherited the Kubernetes default; the neighboring nullable Kubernetes booleans preserve that distinction with optional. Make this field optional as well.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4f68376c5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-09-22T20:03:19Z

+    // Base action (evaluated with args=0).
+    string action = 1;
+    // Argument-level conditions extracted from the BPF filter.
+    repeated ArgCondition conditions = 2;


Preserve compound seccomp predicates

When an effective BPF rule reaches an action only after multiple argument checks (for example, arg0 == x && arg1 == y), this flat condition list cannot record the conjunction or decision-tree edges: every ArgCondition contains only one comparison and its terminal action. A consumer therefore cannot distinguish the compound rule from independent branches and may reconstruct a filter that allows the syscall too broadly; represent condition grouping or the BPF decision structure explicitly.

Useful? React with 👍 / 👎.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d69cf35a9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-09-28T09:34:24Z

+    // Comparison operator: "==", "!=", "&", ">", ">=", "<", "<=".
+    string op = 2;
+    // Constant value compared against.
+    uint64 value = 3;


Add a mask operand for seccomp masked comparisons

When an effective seccomp rule uses masked equality, such as (arg & mask) == datum where the mask and datum differ, this representation has only one value for the & condition. A producer must therefore discard or conflate one operand, and consumers cannot reproduce the extracted filter, which can change the rule's allow/deny behavior. Model the mask and comparison datum separately.

Useful? React with 👍 / 👎.

## What Enrich CWS security profiles with the declared Kubernetes hardening posture (privileged, seccomp profile, capabilities add/drop, bools: runAsNonRoot, allowPrivilegeEscalation, readOnlyRootFilesystem). ## How - `pkg/proto/datadog/workloadmeta` + `comp/core/workloadmeta` — add `ContainerSecurityContext`, `PodSecurityContext`, `Capabilities`, `SeccompProfile` and wire them through `Container` and `KubernetesPod`. - `pkg/security/resolvers/securitycontext` — new `WorkloadmetaResolver` that reads the container's declared posture (falling back to pod-level `runAsNonRoot`/seccomp), derives the template-slot key by walking OwnerReferences (ReplicaSet → Deployment, Job → CronJob via the shared `pkg/util/kubernetes` name-suffix heuristic), applies the node's kubelet seccomp-default, and resolves `Localhost` seccomp profiles to their on-disk filter. - `pkg/security/security_profile` — Profile now carries a `SecurityContexts map[Key]*SecurityContext`. ManagerV2 upserts on profile creation, storage load, and workload linking. ### TODO - [x] New release on `agent-payload` before merging: DataDog/agent-payload#519 Co-authored-by: momar.toure <momar.toure@datadoghq.com>

mftoure added 2 commits September 8, 2026 14:57

add HardeningDeclared

4245a83

fix tests

31fbb06

mftoure changed the title ~~Momar/hardening declared~~ [CWS] Add declared hardening infos Sep 10, 2026

mftoure marked this pull request as ready for review September 10, 2026 11:55

mftoure requested a review from a team as a code owner September 10, 2026 11:55

mftoure mentioned this pull request Sep 10, 2026

[CWS] Add declared hardening infos DataDog/datadog-agent#55994

Merged

1 task done

lebauce reviewed Sep 10, 2026

View reviewed changes

spikat reviewed Sep 10, 2026

View reviewed changes

Comment thread proto/cws/dumpsv1/activity_dump.proto Outdated

mftoure and others added 2 commits September 10, 2026 15:18

rename HardeningDeclared to ContainerSecurityContext

3835e22

cws: key SecurityContext by (namespace, ownerKind, ownerName, contain…

44bb6d8

…erName) Co-authored-by: Cursor <cursoragent@cursor.com>

mftoure force-pushed the momar/hardening-declared branch from 12158e2 to 44bb6d8 Compare September 10, 2026 15:23

lebauce reviewed Sep 14, 2026

View reviewed changes

lebauce approved these changes Sep 14, 2026

View reviewed changes

mftoure added 2 commits September 14, 2026 14:02

ni: if instead of iff

8dfb586

fix codegen

e298f59

spikat reviewed Sep 14, 2026

View reviewed changes

spikat approved these changes Sep 15, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Sep 17, 2026

View reviewed changes

add arguments

ca03251

chatgpt-codex-connector Bot reviewed Sep 17, 2026

View reviewed changes

chante argCondition constant to u64

c4f6837

chatgpt-codex-connector Bot reviewed Sep 22, 2026

View reviewed changes

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: waiting mergequeue-status: removed and removed mergequeue-status: waiting labels Sep 28, 2026

Merge branch 'master' into momar/hardening-declared

2d69cf3

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: queued and removed mergequeue-status: removed mergequeue-status: queued labels Sep 28, 2026

gh-worker-dd-devflow-36fce6 Bot added the mergequeue-status: in_progress label Sep 28, 2026

chatgpt-codex-connector Bot reviewed Sep 28, 2026

View reviewed changes

gh-worker-dd-mergequeue-cf854d Bot merged commit 2478b05 into master Sep 28, 2026
9 checks passed

gh-worker-dd-devflow-36fce6 Bot removed the mergequeue-status: in_progress label Sep 28, 2026

gh-worker-dd-mergequeue-cf854d Bot deleted the momar/hardening-declared branch September 28, 2026 09:36

gh-worker-dd-devflow-36fce6 Bot added the mergequeue-status: done label Sep 28, 2026

Conversation

mftoure commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

Uh oh!

lebauce Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

lebauce Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

spikat Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

spikat Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 22, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Sep 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mftoure commented Sep 8, 2026 •

edited

Loading