Repository navigation
Skip Blender tests cleanly when SPRITEMOTION_BLENDER is missing (TEST-SM-01) - #33
Conversation
Shared requires_blender mark in tests/conftest.py (skipif on SPRITEMOTION_BLENDER / discovery, with a reason), applied to each test in test_blender_loop.py, a repository test that every Blender-starting test carries it, and a CI note saying which jobs have Blender (none of the hosted ones). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08b9821328
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tests = len(re.findall(r"^def test_", text, re.MULTILINE)) | ||
| marked = len(re.findall(r"^@requires_blender\ndef test_", text, re.MULTILINE)) |
There was a problem hiding this comment.
When a Blender test is added as a class method—a test style already used in tests/test_pose_editor.py—the ^def test_ pattern ignores the indented method, so this guard can pass even if the method lacks @requires_blender. Because the module-level pytestmark was removed, that test would run on Blender-free CI and call the helper with no executable instead of being skipped; inspect collected/AST test functions or retain a module-level mark.
Useful? React with 👍 / 👎.
TEST-SM-01 (work/TEST-SM-01, 08b9821 on main ac9209f).
requires_blender in conftest uses spritemotion.blender.find_blender plus an exists check; the three Blender tests carry it; a guard test counts @requires_blender on every test file that starts Blender; ci.yml note on which jobs have Blender.
Director checks: with SPRITEMOTION_BLENDER pointing nowhere, 3 Blender tests skip with a reason and 11 pass. Verdict ACCEPT (switchboard 6916). Moshu merges.
🤖 Generated with Claude Code