Repository navigation
Portability: one Blender finder, no hardcoded Windows paths (closes #12) - #30
Conversation
…Blender paths (issue #12) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…h pattern test Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d514dd038
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| try: return find_blender(REPO) | ||
| except RuntimeError as error: raise SystemExit(str(error)) |
There was a problem hiding this comment.
When Blender is installed only under the newly supported tools/blender-runtime/<version>/ location, the documented pipeline/fit-lab-export launcher never reaches this lookup: both launchers/pipeline/fit-lab-export.sh:7 and .bat:6 require SPRITEMOTION_BLENDER first and exit when it is unset. Thus the fallback works for direct run.py invocations but not the repository's official Fit Lab export launcher; remove or update that launcher precondition so it delegates discovery here.
Useful? React with 👍 / 👎.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
SM-12 + SM-12a (work/SM-12a, 0d514dd). Closes #12.
One Blender finder shared by the tools; the hardcoded-path test's separator class is [/] so it catches backslash and slash paths, with a pattern test (6 hits / 2 misses). Follows #18.
Director checks: repository + portability tests in the worktree venv 14 passed / 1 skipped. Verdict ACCEPT (switchboard 6622). If this merges before the release PR, the release CHANGELOG's #12 line becomes "Issue #12 fixed (#18, #NN)". Moshu merges.
🤖 Generated with Claude Code