Repository navigation
Worktree venv launcher; fixed test order; scipy locked in the test extra - #29
Conversation
…mmon/ launchers/dev/worktree-venv (.bat + .sh) runs tools/worktree-venv/run.py: builds workspace/venv, pip install -e .[test], and fails unless spritemotion.__file__ is this checkout's common/. common.bat/common.sh prefer workspace/venv when it exists. The test extra gains scipy>=1.13 (numpy 2 compatible); pytest addopts gets -p no:randomly. CLAUDE.md checks point at the launchers. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…v.lock uv 0.6.14, uv lock without --upgrade. Adds scipy 1.15.3/1.17.1/1.18.1 (numpy markers per python version) and the imaging/test extra entries pyproject already declared; no existing package versions changed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa274cfaf2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| call "%~dp0config.bat" | ||
|
|
||
| @rem workspace\venv (launchers\dev\worktree-venv) tests THIS checkout; .venvs\spritemotion is main's editable install. | ||
| if not defined SPRITEMOTION_PYTHON if exist "%SM_ROOT%\workspace\venv\Scripts\python.exe" set "SPRITEMOTION_PYTHON=%SM_ROOT%\workspace\venv\Scripts\python.exe" |
There was a problem hiding this comment.
When workspace/venv exists, this assignment makes pipeline/0-setup.bat see an existing SPRITEMOTION_PYTHON, so it skips creating .venvs/spritemotion and installs into the worktree environment instead. The shell twin similarly updates workspace/venv whenever both environments exist because it never resets the selected interpreter to SM_VENV_PYTHON. Consequently, running the documented setup after the worktree setup can leave the shared environment missing or stale; 0-setup should explicitly target .venvs/spritemotion rather than inherit this preference.
Useful? React with 👍 / 👎.
SM-VENV1 + SM-VENV1a (work/SM-VENV1a, aa274cf).
tools/worktree-venv/run.py creates and refreshes a per-worktree venv, with .bat/.sh launchers under the fleet rule; common.bat/.sh prefer workspace/venv. pytest runs in a fixed order (-p no:randomly). uv.lock gains scipy in the test extra (1.15.3 / 1.17.1 / 1.18.1 by Python marker) and the imaging extra main's lock had been missing since #23; requires-dist matches pyproject; uv lock --check clean.
Director checks: repository + portability tests in the worktree venv 14 passed / 1 skipped; uv lock --check clean. Verdict ACCEPT (switchboard 6672). Touches uv.lock, same as the release PR: merge this first, then rebase the release PR. Moshu merges.
🤖 Generated with Claude Code