Skip to content

Add Okta Oauth provider#56

Closed
CrispyBacon1999 wants to merge 1 commit into
Dan6erbond:mainfrom
CrispyBacon1999:main
Closed

Add Okta Oauth provider#56
CrispyBacon1999 wants to merge 1 commit into
Dan6erbond:mainfrom
CrispyBacon1999:main

Conversation

@CrispyBacon1999

Copy link
Copy Markdown

Adds a provider for Okta. Can be used using:

new OktaOAuth2Provider({
    oktaDomain: import.meta.env.VITE_OKTA_DOMAIN as string,
    clientId: import.meta.env.VITE_OKTA_CLIENTID as string,
    clientSecret: import.meta.env.VITE_OKTA_CLIENTSECRET as string
})

@Dan6erbond

Copy link
Copy Markdown
Owner

Nice! One thing - OktaProvider needs to have the provider and its types exported in src/providers/index.ts so that it can be imported as a standard provider.

@Dan6erbond Dan6erbond self-requested a review January 12, 2022 15:47
@Dan6erbond Dan6erbond added enhancement New feature or request help wanted Extra attention is needed labels Jan 12, 2022

@Dan6erbond Dan6erbond left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add OktaProvider and its associated types to src/provders/index.ts.

@cmcculloh-kr

Copy link
Copy Markdown

@Dan6erbond I'm interested in using Okta as an Oauth provider, so I made your requested changes, but I have no idea how to get them into this PR. They're here: https://github.com/cormacmccarthy/sk-auth

@vhscom

vhscom commented May 3, 2022

Copy link
Copy Markdown
Contributor

I'm interested in using Okta as an Oauth provider, so I made your requested changes, but I have no idea how to get them into this PR. They're here: https://github.com/cormacmccarthy/sk-auth

If you based your work off this branch, it's possible for the maintainer to cherry-pick your commit adding the requested work into this branch so it can be tested. If that's the case, please indicate the commits to be cherry-picked or consider opening another Pull Request which wraps up the work and can be used to supersede this one assuming @CrispyBacon1999 is no longer interested in the follow-up work.

@Dan6erbond

Copy link
Copy Markdown
Owner

Closing as #98 supersedes it.

@Dan6erbond Dan6erbond closed this Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants