Skip to content

Mroda/emulation#81

Draft
mroda88 wants to merge 9 commits into
developfrom
mroda/emulation
Draft

Mroda/emulation#81
mroda88 wants to merge 9 commits into
developfrom
mroda/emulation

Conversation

@mroda88

@mroda88 mroda88 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Description

This PR introduces a new RepoManager type so that we can streamline the access to configurations for emulation.

Please also include instructions for how a reviewer can test your changes.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@mroda88 mroda88 self-assigned this Jun 29, 2026
@mroda88 mroda88 added the enhancement New feature or request label Jun 29, 2026
)

## MaR: check with Henry if it's ok to do it here
self.conf_pool.checkout_base(self.daq_version) # type: ignore

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should really be done in select_config since it will change what's loaded in your conf pool

  • Check this breaks the reset button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants