bugfix: Adjustable option reset now resets to the initial value of a parameter + displays that value#77
Open
henry-wallace-phys wants to merge 2 commits into
Open
Conversation
MRiganSUSX
reviewed
Jun 23, 2026
MRiganSUSX
left a comment
MRiganSUSX
left a comment
Contributor
There was a problem hiding this comment.
Thank @henry-wallace-phys.
Just one comment below :)
| return ( | ||
| f"([dim purple]Current Value: [/][bold red]{self._curr_value}[/bold red])" | ||
| f"[dim purple]Current Value: [/][bold red]{self._curr_value}[/bold red]\n" | ||
| f"[dim grey]Init value: [dim red]{self._init_value}[/]" |
Contributor
There was a problem hiding this comment.
There seems to be missing [/] at the end?
Contributor
Author
There was a problem hiding this comment.
Fixed (although in practice, the [bold red] will override the [dim grey] but I agree this is sensible to avoid any accidental conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjustable option reset now resets to the initial value of a parameter + displays that value
Test by changing adjustable attribute + pressing reset
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)daqsystemtest_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))