Skip to content

bugfix: Ensure "create" pop up correctly quits#76

Open
henry-wallace-phys wants to merge 2 commits into
developfrom
hwallace/bugfix/quit_screen
Open

bugfix: Ensure "create" pop up correctly quits#76
henry-wallace-phys wants to merge 2 commits into
developfrom
hwallace/bugfix/quit_screen

Conversation

@henry-wallace-phys

@henry-wallace-phys henry-wallace-phys commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Description

Fix bug where if "Create" menu is opened, canceled + then re-opened it cannot be quit

Test by clicking cancel after opening the Create menu more than once

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@MRiganSUSX MRiganSUSX left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @henry-wallace-phys.
Just one comment below :)

)


def test_overlay_screens_registered_in_screens():

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, I understand that create and quit were correctly removed, bit load and help are still registered? This should be trimmed to cover the existing cases, not removed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can but I actually don't like that in prinicipal. It's an extremely constraining test that I don't think is particularly useful as it just checks if a hardcoded list contains the things it's hardcoded to contain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants