Add error message when failing to load DAQModule plugins#365
Open
eflumerf wants to merge 3 commits into
Open
Conversation
commonly happen during unit testing.
Member
Author
|
Possibly something in DUNE-DAQ/logging#45 |
bieryAtFnal
approved these changes
Jun 30, 2026
bieryAtFnal
left a comment
Contributor
There was a problem hiding this comment.
I confirm that I see the following message in the output from the appfwk unit tests when I use the code on this branch.
2026-Jun-30 10:57:36,136 ERROR [dunedaq::appfwk::make_module(...) at /home/nfs/biery/dunedaq/30JunFDDevLBIteratorTesting/sourcecode/appfwk/include/appfwk/detail/DAQModule.hxx:48] Failed to create DAQModule error_test of type not_a_real_plugin_name
IllegalUnderscore. Library specification "not_a_real_plugin_name" contains an illegal underscore.
Member
Author
Wait, this is really interesting! Apparently, the unit test has been testing the wrong thing all this time! The intent was to test trying to load a plugin type that doesn't exist, but apparently we've actually been testing an invalid plugin name format! |
Contributor
|
I confirm that I now see two "new" error messages: and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add an ers::error report of DAQModuleCreationFailed to ensure output when running in unit tests.
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)dunedaq_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Comments here on the testing
Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))