feat!: reimplement dtocean-economics#68
Merged
Merged
Conversation
H0R5E
force-pushed
the
dtocean_economics
branch
from
751f471 to
93e8825
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 76.69% 77.08% +0.39%
==========================================
Files 200 205 +5
Lines 32767 33352 +585
Branches 34 34
==========================================
+ Hits 25131 25711 +580
- Misses 7628 7633 +5
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
H0R5E
force-pushed
the
dtocean_economics
branch
from
cf82038 to
6307bf0
Compare
Already done: + Converted to Python 3 + Converted to Poetry + Running tests from 3.12 to 3.14
Also add contourpy as dependency for stats module
I'm considering removing the main module entirely and just calling the functions individually.
Requires testing
Automatically generated by python-semantic-release
Automatically generated by python-semantic-release
Delete test release workflow
Also set all opex in year 0 to 0. Euro in test setups.
H0R5E
force-pushed
the
dtocean_economics
branch
from
965b8d3 to
8ebd20e
Compare
H0R5E
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request reimplements the dtocean-economics code in Python 3 and incorporates it into the new plugin architecture.
The PR makes the following changes to dtocean-economics:
Added
Changed
costs_from_bomfunction toadd_costs_to_bomand included discounted costs in the given dataframeRemoved
get_combined_lcoe,get_lcoeandget_total_costfunctionsCloses #57